search

nextcloud / integration_moodle

🎓 Moodle integration into Nextcloud
GNU Affero General Public License v3.0
15 stars 5 forks source link

Correct the "more notifications" URL #5

Closed Dagefoerde closed 3 years ago

Dagefoerde commented 3 years ago

Thanks @pkmkrishnakumar for reporting this and for proposing the correct URL in #4. That URL is the right one in our Moodle, too. Here's a PR with the fix.

julien-nc commented 3 years ago

@Dagefoerde Thanks a lot.

This makes me remember that it feels weird to display recently accessed modules and upcoming events in the widget while the "more" button leads to notifications that might be unrelated. I'm interested if you have any clue how to get notifications with the API.

Dagefoerde commented 3 years ago

Fair enough. I can look into that. But maybe notifications are not all that important in this widget? instead of linking to the list of notifications, we could provide a link to the Moodle dashboard (/my). In a default configuration it lists recently accessed courses and shows a calendar. In non-default configurations the dashboard could be useful as well.

So, maybe replace the link entirely (the new one for the dashboard could be named "Moodle Dashboard") or provide a combination of the two.

julien-nc commented 3 years ago

Right, it makes much more sense to have a link to Moodle's dashboard. Let's do that and let's put the question on table again if the widget displays Moodle notifications in the future.

Thanks for sharing your thoughts!

pkmkrishnakumar-zz commented 3 years ago

Having both notifications and a link to dashboard is appreciated. While if dashboard is incorporated, then the widget should be wide. Wide means similar to tiles interface (something like small tile and wide tile)

How to update the fix in the current installation? Can you guide please.

julien-nc commented 3 years ago

@pkmkrishnakumar You can wait for next release (a few days tops) and update or you can install the app from the sources yourself (not recommended if you don't know what you are doing):

Approximate procedure :grin: :

apt install npm make
cd /var/www/.../nextcloud/apps
rm -rf integration_moodle
git clone https://github.com/nextcloud/integration_moodle
cd integration_moodle
make
pkmkrishnakumar-zz commented 3 years ago

@eneiluj

Thanks I tried but i had some error with make (it displayed thaere is some error within npm)

But later I tried to replace the backup of the integration_moodle in apps folder

I am unable to view the notifications in the Dashboard.

image

I also tried to remove the folder manually and install using the zip from app.nextcloud.com

pkmkrishnakumar-zz commented 3 years ago

And now i checked with Integration of Important Mail also is displaying similar to previous error.

But other widgets like Announcement, Notes, Upcoming events are working great

image

At the same time i noticed the https://apps.nextcloud.com/ is also not reachable

julien-nc commented 3 years ago

Don't know what you did but Mail widget error is unrelated.

Press CTRL+F5 to make sure cache is emptied when reloading.

Btw if the compilation error you got is something like

ERROR in No configuration provided for /.../apps/integration_moodle/src/components/PersonalSettings.vue

you can ignore it.

pkmkrishnakumar-zz commented 3 years ago

I tried with other browsers and other users, still problem persists. Tried using incognito mode as well in Google Chrome and Private mode in Firefox.

I had compilation error with npm.

image

So I deleted the integration_moodle folder itself and copied the contents which I backed-up earlier to compilation

And when connecting to moodle it shows like this, endless

image

I hope the token prior to update is not working after update. In such case how to update it.

Is there any other possibilities to start from scratch and reuse the app

By the way Moodle supports Oauth 2.0 , already nextcloud can be integrated with moodle for file picker as an repository. Similar to github , nextcloud shall use Oauth for client id instead of individual tokens

pkmkrishnakumar-zz commented 3 years ago

Problem Solved !!! Thanks to @eneiluj

Out of curiosity, is there any dependency of app store for moodle integration to work properly. For the past 2 days app store had some issue by the same time we had issues in moodle notification. But today, without doing any changes, moodle notification app started to work automatically by the same time app store is also restored.

Thanks for the wonderful app. Hope to have more integration using api as well

julien-nc commented 3 years ago

@pkmkrishnakumar

is there any dependency of app store for moodle integration to work properly

No, totally unrelated :grin:

By the way Moodle supports Oauth 2.0

As far as I've seen or understood, Moodle can be an OAuth client and connect to other services. But I didn't find a way to setup something and connect to Moodle with OAuth (with Moodle being the OAuth provider). If you find a clear documentation about that, I'm interested.

Thanks for the enthusiasm! Integrations will probably be improved and extended by me or anyone else. If you have ideas or want to make a PR, you are very welcome.

Cheers

Dagefoerde commented 3 years ago

As a developer from the Moodle community, I can chime in: Exactly, as of now Moodle can only serve as an OAuth 2 Client, but not as a provider.

Dagefoerde commented 3 years ago

Oh by the way, since it is Hacktoberfest: @eneiluj would you be so kind to add a hacktoberfest-accepted label to this PR? Thank you 🙂️

julien-nc commented 3 years ago

Moodle can only serve as an OAuth 2 Client, but not as a provider

@Dagefoerde Thanks for having confirmed this. I can now stop searching for it :grin:.