nextcloud / integration_slack

Slack integration in Nextcloud
GNU Affero General Public License v3.0
2 stars 2 forks source link

[bug] not all channels are displayed #8

Open ferdiga opened 1 year ago

ferdiga commented 1 year ago

it would be probably helpful to describe which permissions are necessary. As the channels are neither sorted nor searchable, I can not determine wich channels are missing. I am sure that not all public channels are listed, nor my private ones. May be this is also a Slack app configuration issue.

Slack-NC App can: View information about a user’s identity, granted by 1 team member View basic information about public channels in a workspace, granted by 1 team member View basic information about a user’s private channels, granted by 1 team member View basic information about a user’s direct messages, granted by 1 team member View basic information about a user’s group direct messages, granted by 1 team member View people in a workspace, granted by 1 team member Send messages on a user’s behalf, granted by 1 team member Upload, edit, and delete files on a user’s behalf, granted by 1 team member

kyteinsky commented 8 months ago

Hi, all the permissions are required for different parts of the app to function.

View information about a user’s identity, granted by 1 team member

Used to display the profile picture and the user ID in 'Connected Accounts' section of user settings

View basic information about public channels in a workspace, granted by 1 team member View basic information about a user’s private channels, granted by 1 team member View basic information about a user’s direct messages, granted by 1 team member View basic information about a user’s group direct messages, granted by 1 team member

For listing all the conversations, their icons and other related info

View people in a workspace, granted by 1 team member

not sure where this comes from, maybe from users:read, which is required to fetch one's own avatar

Send messages on a user’s behalf, granted by 1 team member Upload, edit, and delete files on a user’s behalf, granted by 1 team member

To send messages and files

The complete list of permissions this app requests: https://github.com/nextcloud/integration_slack/blob/main/src/utils.js#L27

I think with all the given permissions for conversations, it should list all of them. Can you provide examples of conversations/conversation types that are missing from the list?

ferdiga commented 8 months ago

Hi After update to 28.0.3 and slack integration 1.1 solved:

open:

kyteinsky commented 6 months ago

still not all (public) channels are displayed

would you mind posting a screenshot or something similar? It shows the complete list (private + public) for me.

ferdiga commented 6 months ago

Hi, it's obviously difficult to show channels which are not shown ;-)

in NC i type "terrain_hm" and it returns only 2 of the many channels 20240503.170305.Files.pdf

kyteinsky commented 2 weeks ago

Hello, see if the new release fixes this issue for you. Otherwise I got no idea why some channels are not shown.

adm-romanb commented 1 week ago

Hello, see if the new release fixes this issue for you. Otherwise I got no idea why some channels are not shown.

Still have this issue with 2.0 version. It shows only 20 channels (including channels I'm not a member of). I'm a member of a big amount of channels so may be big list of channels cause some issue?

ferdiga commented 1 week ago

here it shows "ONLY" 100 channels , sorted alphabetical now and string selection works (inside the set of 100).

my guess is, that it shows the first 100 created (by date) which probably corresponds to the first 100 ids of the records.

kyteinsky commented 1 week ago

Thank you @adm-romanb and @ferdiga for your very useful observations!

@adm-romanb The endpoint for list of channels now fetches only channels the calling user is part of. You might an admin and have seen conversations other users are part of in the list. I'm not sure about the only 20 channels issue, how many should be there? See if the new release will fix it or create a new issue. Also, set the 'loglevel' => 0, in the config/config.php file to see how many conversations are received from Slack side.

@ferdiga Yes, that is exactly what happened. I think at the time I must have assumed people won't have more than 100 conversations and the "limit" option was forgotten. Now it will fetch all the conversations there are, in 1000 conversation chunks.

adm-romanb commented 1 week ago

With version 2.0.1 channels listing is broken. At first it was trying to get channels for a long time. Then it instantly shows an error "Failed to load Slack channels" Logs are attached.nextcloud_slack.log

I'm not sure about the only 20 channels issue, how many should be there? At least 60 public channels and 65 private ones.

kyteinsky commented 1 week ago

There are no errors reported in the logs. Do the browser console logs have something? (Ctrl + Shift + i)

KMarkOne commented 6 days ago

Image

Hi, channel listing does not work at all.

kyteinsky commented 6 days ago

hi, can you post the server logs (tail -n50 data/nextcloud.log in the server) and the browser logs (Ctrl + Shift + i)? After clicking on the refresh icon above the channel list.

KMarkOne commented 5 days ago

hi, can you post the server logs (tail -n50 data/nextcloud.log in the server) and the browser logs (Ctrl + Shift + i)? After clicking on the refresh icon above the channel list.

Currently I can send only the browser logs. Hope it helps.

SendFilesModal.vue:387 TypeError: Cannot read properties of null (reading 'localeCompare') at SendFilesModal.vue:381:1 at Array.sort () at Array. (vue.runtime.esm.js:777:31) at SendFilesModal.vue:381:1 (anonymous) @ SendFilesModal.vue:387 Promise.catch updateChannels @ SendFilesModal.vue:385 ye @ filesplugin.js:54 be @ filesplugin.js:95 exec @ filesplugin.js:75 onActionClick @ FileEntryActions.vue:161 click @ FileEntryActions.vue:4 hn @ vue.runtime.esm.js:3033 n @ vue.runtime.esm.js:1832 hn @ vue.runtime.esm.js:3033 e.$emit @ vue.runtime.esm.js:3732 onClick @ actionText-fFcUPi2g.mjs:77 handleClick @ NcActionButton.mjs:131 hn @ vue.runtime.esm.js:3033 n @ vue.runtime.esm.js:1832 Yr.i._wrapper @ vue.runtime.esm.js:7500