5.4.0: image preview fixed to square

[bcutter]

Since 5.4.0 the preview of HEIC files is only shown as square/quadratic. That of course hides parts of the image making the preview useless in many cases.

• It does not affect PNG or other file types.

• Once the full size of the image is loaded (manually), the HEIC is shown fully (in original aspect).

Random example:

1) Full image

2) Nextcloud iOS 5.4.0 preview

3) Nextcloud iOS full size view

[rightsaidfred99]

For me, it happens with regular jpegs

[marinofaggiana]

@bcutter your example is incomprehensible :D bette choice another image

[bcutter]

The image itself is irrelevant. You should get the point with the description only. Otherwise... you could just try it on your own I guess?

[marinofaggiana]

I don't understand whats do you mean for description ?

[marinofaggiana]

the preview image is requested with the dimensions (H-W) resized based on the values ​​given by the metadata, if they are not there (probably they are not given for HEIC files) I cannot know the size to request.

[bcutter]

Did you read the issue description?

In basic words: the image preview only shows this (square) and cuts other parts.

[bcutter]

the preview image is requested with the dimensions (H-W) resized based on the values ​​given by the metadata, if they are not there (probably they are not given for HEIC files) I cannot know the size to request.

Well, something changed compared to the version before 5.4.0.

This behavior is definitely new and introduced with 5.4.0.

Previews were working fine before, now they are broken.

[bcutter]

Here's a way better example image (widescreen).

Upload it and check the preview:

[marinofaggiana]

the preview image is requested with the dimensions (H-W) resized based on the values ​​given by the metadata, if they are not there (probably they are not given for HEIC files) I cannot know the size to request.

Well, something changed compared to the version before 5.4.0.

This behavior is definitely new and introduced with 5.4.0.

Previews were working fine before, now they are broken.

mm this happen ONLY with HEIC ? (for make some test)

[bcutter]

No, @rightsaidfred99 is right: also for JPEGs (like the last widescreen one I provided before).

[rightsaidfred99]

jsut on the ios app too, the web interface is fine

[rightsaidfred99]

Nextcloud Hub 8 (29.0.3) It's just the iOS update from today or yesterday that broke things. Server hasn't updated for a few weeks