search

nextcloud / ios

📱 Nextcloud iOS App
https://itunes.apple.com/us/app/nextcloud/id1125420102
GNU General Public License v3.0
1.99k stars 884 forks source link

add option to sync favorites only #3105

Closed sp00ktober closed 4 weeks ago

sp00ktober commented 1 month ago

Implements #2615 replaces #3102

This adds an option to the Auto Upload settings to only sync those assets marked as favorites through the Apple Photos App.

I did some testing in the simulator and with my own Nextcloud server. I am open for improvements of this PR, especially regarding localization. Not sure if i did this the right way or not.

This is just a super handy feature for myself and i was missing it in the app, so i added it.

marinofaggiana commented 1 month ago

Hi @sp00ktober very thanks !! when I have a moment of time I watch it

(please resolve the conflict ... in de ?)

sp00ktober commented 1 month ago

Hey @marinofaggiana thanks for having a look, would be very cool to see this in the app at some point :)

I updated to current develop state and fixed the conflict.

sp00ktober commented 1 month ago

@marinofaggiana i updated to latest dev branch and fixed the merge conflict, however i am not longer able to build the app due to other changes (mainly NCLivePhoto and the setLivephoto() function)

sp00ktober commented 4 weeks ago

Fixed merge conflicts. Is there anything more needed from my side on this one or any way i can help to let this progress? I was able to build and test the app in the simulator again and it was working as expected.

marinofaggiana commented 4 weeks ago

Thanks @sp00ktober will be some test !

marinofaggiana commented 3 weeks ago

there are some things to be done but in the meantime thanks

sp00ktober commented 3 weeks ago

thanks too for merging, this feature could save me a lot of manual work :)

Is this now part of version 6.0.1 or 6.1.0?