search

nextcloud / ios

📱 Nextcloud iOS App
https://itunes.apple.com/us/app/nextcloud/id1125420102
GNU General Public License v3.0
1.99k stars 884 forks source link

Image files "upload" in wrong format #3163

Closed biggreenogre closed 2 weeks ago

biggreenogre commented 2 weeks ago

How to use GitHub

Steps to reproduce

  1. Open Nextcloud from IOS home screen
  2. Select "More" in bottom right of screen
  3. Tap "Settings"
  4. Tap "Advanced"
  5. Ensure "Most Compatible" is turned OFF
  6. Select "Files" in bottom left of screen
  7. Tap "+" n bottom centre of screen
  8. Tap "Upload photos or videos"
  9. Select a photo
  10. Tap "Done" in top right of screen
  11. View file list

Expected behaviour

Photo has been "uploaded" as "IMG_1234.HEIC"

Actual behaviour

Photo has been "uploaded" as "IMG_1234.PNG"

Logs

If applicable, you can post the iOS app or server logs (removing any sensitive information).

N/A

Reasoning or why should it be changed/implemented?

File format should not be converted unless option "Most Compatible" is turned ON. I noticed this whilst creating and attaching screenshots for two other bug reports with this release. https://github.com/nextcloud/ios/issues/3161 https://github.com/nextcloud/ios/issues/3162

Environment data

iOS version: e.g. iOS 17.6.1 17.7.1 Nextcloud iOS app version: see More > Settings 6.1.3.0 Server operating system: "Raspbian GNU/Linux 10 (buster)" Web server: Apache, nginx Apache Database: Mariadb PHP version: 7.3 Nextcloud version: see Nextcloud admin page 23.0.12

marinofaggiana commented 2 weeks ago

mmm for my test works ... @mpivchev @i2h3 can you try ?

@biggreenogre are you sue that the source image is HEIC format ?

i2h3 commented 2 weeks ago

@biggreenogre Can you tell which format your taken photos usually have? You can check in the iOS system settings under Camera → Formats. May be labelled differently, I only have it set to German at hand right now.

If you have selected "High Efficiency", then the system will save the photos as HEIC instead of the more compatible JPEG which has been around for longer. Then the behavior is as expected because the photo is uploaded as it is.

i2h3 commented 2 weeks ago

@marinofaggiana I took a HEIC photo on my iPhone, uploaded it in the described way with the maximum compatibility setting of the Nextcloud app turned off and it ended up as HEIC on the server. With the app setting turned on, it ended up there as JPG. Appears to work as expected for me.

biggreenogre commented 2 weeks ago

The images that were uploading as PNG were screenshots. I just tried an actual photo and it was uploaded as HEIC. It didn't occur to me that screenshots would be in a different format though it now makes sense. Apologies for the false alarm. :-}