nextcloud / ios

📱 Nextcloud iOS App
https://itunes.apple.com/us/app/nextcloud/id1125420102
GNU General Public License v3.0
1.92k stars 867 forks source link

View HEIC picture #737

Open dkeso opened 5 years ago

dkeso commented 5 years ago

Expected behaviour

Show a HEIC image, even when is not cached on device, when is opened with Nextcloud iOS app. (Also, maybe preview the image, but I imagine that preview would require server compatibility). It works if the file is in cache, so if you press "picture menu -> open in.." you can preview the image as it will be downloaded first.

Actual behaviour

After touching a HEIC image, a blank screen with the nextcloud blue header with the message "Loading..." is showed.

Steps to reproduce

  1. Upload a HEIC image from computer to Nextcloud files.
  2. Go to the nextcloud folder with the Nextcloud iOS app.
  3. Open the HEIC image.

iOS version

iPhone 8 up to date (iOS 12.1)

App version

2.22.5.10

Server configuration

Operating system: Debian testing

Web server: Apache 2.4.37-1

Database: MySQL 5.6.30-1

PHP version: 7.2

Nextcloud version: (see Nextcloud admin page) 14.0.4

Thank you very much for your AWESOME work!

marinofaggiana commented 5 years ago

Hi @dkeso try the new version in TestFlight (soon on App Store) 2.22.6

dkeso commented 5 years ago

It works! Thank you very much!

Just one question, I'm testing with a HEIC picture that was taken as a "live" picture, but after downloading it from Nextcloud it is no longer "live". Why this happens?

Thank you!

EDIT: I'. not expecting in-app live photos, I'm just curios why the file uploaded to Nextcloud is not live once downloaded again to the iPhone! :)

marinofaggiana commented 5 years ago

@dkeso the live photo is a photo + internal full hd H.264 video: we use only the photo

dkeso commented 5 years ago

Hi, @marinofaggiana Thank you for your reply. That means that the file uploaded by the photos/videos autoupload desn't contain the internal FHD H.264 video? Because it is very important to me to keep the live version of my pictures. I'm ok if I have to download it to camera roll first, but I think that photo+internal_video are really needed.

Thank you very much!

P.S.: any "tip button" for nx ios? I really love this project.

marinofaggiana commented 5 years ago

@dkeso this is in TODO list but, for now, is not a priority.

marinofaggiana commented 5 years ago

sorry, re-open.

thibaultamartin commented 4 years ago

Hey @marinofaggiana thanks for your work on the app, it's truly great!

I'm considering migrating completely out of iCloud, but I want to make sure I won't lose any data, and that the process can be reversed. I have two questions then.

About data loss : If I take a Live Photo on my phone and have the auto-upload activated on the Nextcloud app, will it upload the photo + video as this issue suggests? Will it automatically create a new folder, upload the photo and the video, and not lose any metadata they carry?

About reversibility : If I upload a Live Photo from my phone to the Gallery, wipe the phone, and download back what was uploaded to my instance, will I have a Live Photo or a photo+video on my phone?

Thanks a lot!

Itja commented 4 years ago

Please correct me if I'm wrong, but it seems, that at the moment, Nextcloud converts all HEIC to JPG before uploading, so you'll lose the video in the process @thibaultamartin .