Closed marinofaggiana closed 5 years ago
It seems like a very nice implementation of the Gallery feature! Yes, it really hammers the Server DB, and creates high load, but, nah, what ever π
-There seems to be an issue with the date annotation shown. In my app it stops at 12th of January 19, but scrolls down the pictues just fine.
-The pictures are more or less completely out of order, at least they are not sorted date wise.
-The app did crash only once.
-Yesterday it was not possible to scroll down to pictures beyond ~30 Days ago...
But still very nice step in the right direction.
Build 1,2:
Hi @AndrewwHummer
-The pictures are more or less completely out of order, at least they are not sorted date wise.
mmm look
-The app did crash only once.
mmm no this is not good (how ?)
The app crashed when I just scrolled down very far, at some point it started to lag and suddenly, IOS seemed to kill the app, just exiting to homescreen...
The funny stuff begins after Sunday 12 Janurary for me. Ah wait a second, thats where the old media Tab continuously crashed the app completely... I guess that there is something in my database that is not really straight....
Ah damn, I just found out that the file creation date is used, so not the embeeded data information in the picture, or even the file name that could be interpreted. So no wonder that after the 12th January 19 there is no new date/new photos π― And no wonder the pics are not in any specific order.
Is there a way to change the sorting?
@AndrewwHummer try the build 4
ItΒ΄s way more stable. I will test some things. But for now it seems like a huge improvment!
This is a great improvement over the previous media view. I can see my pictures from the last 30 days, however, when I scroll to the bottom I see a spinner but it never shows more pictures and eventually the spinner disappears. I am using 2.23.1.
In any case, this is looking very promising :)
@jcreixell, strange, the date fields in your database are ok ?
@marinofaggiana I think so, at least in web it works well. Let me know if I can help with debugging.
@jcreixell Oh! I have an idea: Often the media view exceeds the standard mysql connection limit of 100. Thus the database kills the connection to Nextcloud. This would be noted prominently in the logs. So if you can: look at your mysql stats and look out for connections used and the connection limit.
Also take a look at the nextcloud server log! π Maybe post the server log :)
Added 3D touch
Ah damn, I just found out that the file creation date is used, so not the embeeded data information in the picture, or even the file name that could be interpreted. So no wonder that after the 12th January 19 there is no new date/new photos π― And no wonder the pics are not in any specific order.
Is there a way to change the sorting?
+1 on this. It is common for lots of media tools, especially while exporting media, to change the creation date of a file. The current mechanism always shows newest files (in terms of creation date of the file itself) first. This lead to a media view which is unsorted. So I'd love to see a possibility to sort for filename or even the creation date in the metadata.
Anyway, the media view is already a great enrichment!
@AndrewwHummer sorry, unfortunately I don't have access to these logs as I am using a hosted solution :(
Known Issues:
New version algorithm:
Start: verify the internal DB, if this is empty request it on server all image/video of 30 days old from now, if don't return metadata (or the total records are < 100) send a new request for the last 90gg .. after 180 gg ... 365 gg and if do not exists metadata send a request for "Distant past".
Update: when you move the scrollbar (at the end of move) or go back in this view the procedure detect the "window" of date present on screen and send a request to server for this step of date (webDAV: lte - gte), verify it the difference of this records with the records in DB, if exists a difference update the view, otherwise it 'does not matter.
At the end of the collection: as start, send a request for other 30 day old from the last data, if don't return metadata (or the total records are < 100) send a new request for the last 90gg .. after 180 gg ... 365 gg and if do not exists metadata send a request for "Distant past".
The download of preview happen only when the scroll bar is stops (reduce traffic on network)
Now is possible (manually) required a refresh with the refresh Control.
Now is possible resize the preview image (see capture below).
Code in swift 4
When start (DB empty) the time and, the network traffic, required is very very short and do not require wait.
New Fast Scroll: https://github.com/marinofaggiana/FastScroll
The first unstable version 2.23.1.0 well be available soon on TestFlight.