nextcloud / ios

πŸ“± Nextcloud iOS App
https://itunes.apple.com/us/app/nextcloud/id1125420102
GNU General Public License v3.0
1.95k stars 879 forks source link

New view "Media" #796

Closed marinofaggiana closed 5 years ago

marinofaggiana commented 5 years ago

Known Issues:

New version algorithm:

simulator screen shot - iphone xs max - 2019-02-19 at 11 58 04

simulator screen shot - iphone xs max - 2019-02-19 at 13 09 34

simulator screen shot - iphone xs max - 2019-02-19 at 13 09 17

The first unstable version 2.23.1.0 well be available soon on TestFlight.

AndrStnz commented 5 years ago

It seems like a very nice implementation of the Gallery feature! Yes, it really hammers the Server DB, and creates high load, but, nah, what ever πŸ˜„

-There seems to be an issue with the date annotation shown. In my app it stops at 12th of January 19, but scrolls down the pictues just fine.

-The pictures are more or less completely out of order, at least they are not sorted date wise.

-The app did crash only once.

-Yesterday it was not possible to scroll down to pictures beyond ~30 Days ago...

But still very nice step in the right direction.

marinofaggiana commented 5 years ago

Build 1,2:

simulator screen shot - iphone xs max - 2019-02-20 at 14 46 07

marinofaggiana commented 5 years ago

Hi @AndrewwHummer

-The pictures are more or less completely out of order, at least they are not sorted date wise.

mmm look

-The app did crash only once.

mmm no this is not good (how ?)

AndrStnz commented 5 years ago

The app crashed when I just scrolled down very far, at some point it started to lag and suddenly, IOS seemed to kill the app, just exiting to homescreen...

The funny stuff begins after Sunday 12 Janurary for me. Ah wait a second, thats where the old media Tab continuously crashed the app completely... I guess that there is something in my database that is not really straight....

AndrStnz commented 5 years ago

Ah damn, I just found out that the file creation date is used, so not the embeeded data information in the picture, or even the file name that could be interpreted. So no wonder that after the 12th January 19 there is no new date/new photos πŸ’― And no wonder the pics are not in any specific order.

Is there a way to change the sorting?

marinofaggiana commented 5 years ago

@AndrewwHummer try the build 4

AndrStnz commented 5 years ago

ItΒ΄s way more stable. I will test some things. But for now it seems like a huge improvment!

jcreixell commented 5 years ago

This is a great improvement over the previous media view. I can see my pictures from the last 30 days, however, when I scroll to the bottom I see a spinner but it never shows more pictures and eventually the spinner disappears. I am using 2.23.1.

In any case, this is looking very promising :)

marinofaggiana commented 5 years ago

@jcreixell, strange, the date fields in your database are ok ?

jcreixell commented 5 years ago

@marinofaggiana I think so, at least in web it works well. Let me know if I can help with debugging.

AndrStnz commented 5 years ago

@jcreixell Oh! I have an idea: Often the media view exceeds the standard mysql connection limit of 100. Thus the database kills the connection to Nextcloud. This would be noted prominently in the logs. So if you can: look at your mysql stats and look out for connections used and the connection limit.

Also take a look at the nextcloud server log! πŸ‘ Maybe post the server log :)

marinofaggiana commented 5 years ago

Added 3D touch

khlschrnk commented 5 years ago

Ah damn, I just found out that the file creation date is used, so not the embeeded data information in the picture, or even the file name that could be interpreted. So no wonder that after the 12th January 19 there is no new date/new photos πŸ’― And no wonder the pics are not in any specific order.

Is there a way to change the sorting?

+1 on this. It is common for lots of media tools, especially while exporting media, to change the creation date of a file. The current mechanism always shows newest files (in terms of creation date of the file itself) first. This lead to a media view which is unsorted. So I'd love to see a possibility to sort for filename or even the creation date in the metadata.

Anyway, the media view is already a great enrichment!

jcreixell commented 5 years ago

@AndrewwHummer sorry, unfortunately I don't have access to these logs as I am using a hosted solution :(