search

nextcloud / jitsi

Nextcloud Jitsi Integration
GNU Affero General Public License v3.0
28 stars 9 forks source link

src/Room.vue: buttons to join via App (desktop and mobile) #12

Closed t-lo closed 1 year ago

t-lo commented 1 year ago

This change adds 2 buttons at the bottom of the Room page which allow users to join a Jitsi room via the Jitsi Desktop app and the Jitsi Mobile app, respectively.

The change moves calculations of the corresponding join URLs into computed() as the button URLs are required when the page loads. Joining with the desktop app requires the URL to be prefixed with jitsi-meet://, while the mobile app requires http[s]://.

The "Join using the Jitsi App" section was updated to provide help for joining with the Jitsi app. The calculated join HTTPS URL is re-used there; a user may fall back to pasting this URL into the Jitsi app should the buttons not work for them.

Tested on Linux (Fedora 36) with Chrome (106.0.0.0) and Firefox (105.0), on Windows 11 with Edge (105.0.1343.53) and Firefox (104.0), and on Android 12 with Firefox (105.0) and Chrome (105.0.0.0).

Resolves #8 .

Screenshots

PC

nextcloud-jitsi

Android

nextcloud-jitsi-mobile

t-lo commented 1 year ago

Rebased on latest master.

weeman1337 commented 1 year ago

Oh - next time please assign me as reviewer. Otherwise I may miss the notifications.

weeman1337 commented 1 year ago

I may open another PR soon to tweak some points…