search

nextcloud / mail

💌 Mail app for Nextcloud
https://apps.nextcloud.com/apps/mail
GNU Affero General Public License v3.0
851 stars 263 forks source link

Potential dependency hell with assistant and html2text #10404

Open ChristophWurst opened 16 hours ago

ChristophWurst commented 16 hours ago

Steps to reproduce

  1. Install Mail
  2. Install Assistant
  3. ???

Expected behavior

No dependency collision

Actual behavior

https://github.com/nextcloud/assistant/blob/38c12770be3a2c29c0c022323b407aa630dab279/composer.json#L17 https://github.com/nextcloud/mail/blob/a94118bf2c36cfcf84ef3666190d5975f47888a3/composer.json#L32

^ we use a patched one. If the assistant html2text is loaded first we'll have a problem in Mail.

Mail app version

No response

Nextcloud version

No response

Mailserver or service

No response

Operating system

No response

PHP engine version

None

Nextcloud memory caching

No response

Web server

None

Database

None

Additional info

cc @julien-nc @hamza221

hamza221 commented 13 hours ago

we can retry our luck with https://github.com/mtibben/html2text/pull/116 and switch back to the main package

ChristophWurst commented 13 hours ago

That is good. The underlying problem of discrepancies between the html2text used/shipped by the two apps will still not be solved.

This seems to be ok right now, hence "Potential". But we have had other cases of dependencies that were used in 2+ apps, upgrade in one and caused an issue in the other(s).

https://docs.nextcloud.com/server/latest/developer_manual/app_development/dependency_management.html#dependency-hell