nextcloud / mail

💌 Mail app for Nextcloud
https://apps.nextcloud.com/apps/mail
GNU Affero General Public License v3.0
839 stars 259 forks source link

Ability to directly view further attachments from email #5988

Open Bibo-Joshi opened 2 years ago

Bibo-Joshi commented 2 years ago

Feature Request

5701 was marked as closed by #5898, but IISC that only adds previews for images and not other files (e.g. pdfs). the preview is also only renders a small thumb at the bottom of the mail and one can't view the picture in full-screen without downloading it to PC/NC. (Please correctly me, if I got anything wrong here!)

From #2225 I understand that it's not straight forward to display arbitrary files, also because interaction with other NC components is necessary. However, from the discussion in #5701 and #5898 it's not clear to me whether or not previewing other file types is completely dropped or not. If it's too complicated to get on any road map, feel free to close. If there is a chance that this could be implemented at some point, I would ask to keep this open :)

Summary

Ideally, I would like a preview to use the default tool assigned for the file type (if there is one), e.g. the markdown editor for .md files, pdf viewer for pdfs, OnlyOffice for .docx & friends, …

TBH, right now I'd already be happy if I could print PDF-attachments without having to download them to my PC/NC first :D

jancborchardt commented 2 years ago

Agree on that – https://github.com/nextcloud/mail/issues/5701 called for the ability to directly open it in a Viewer, and that is still valid.

ChristophWurst commented 2 years ago

@jancborchardt please specify a list of MIME types that we have to support to remove another misunderstanding.

jancborchardt commented 2 years ago

@ChristophWurst sorry, misunderstood that https://github.com/nextcloud/mail/pull/5898 did do a viewer for images but is not deployed yet, which is already nice. :)

Then for further viewing it would be nice if Mail supports the same file types for viewing that the Files app also supports – not sure where that list is, but the essentials beyond images would probably indeed be the ones @Bibo-Joshi mentioned:

jancborchardt commented 2 years ago

(Also, is there a specific reason we use a modal and not the same Viewer as in the Files app?)

GretaD commented 2 years ago

(Also, is there a specific reason we use a modal and not the same Viewer as in the Files app?)

yes, attachments are saved in user folder which means that we cannot use viewer because viewer doesnt support that.

jancborchardt commented 2 years ago

(Also, is there a specific reason we use a modal and not the same Viewer as in the Files app?)

yes, attachments are saved in user folder which means that we cannot use viewer because viewer doesnt support that.

Thanks for the explanation! Briefly talked with Christoph about that too, would of course be nice to make the Viewer compatible for this too, but I understand this is some work. cc @skjnldsv

ChristophWurst commented 2 years ago

There is more discussion at https://github.com/nextcloud/mail/issues/2225.

no-response[bot] commented 2 years ago

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

Bibo-Joshi commented 2 years ago

Just double checking, because the responses were mixed: Is the auto-close desired b/c this feature is too complicated or is it a false-positive?

danir-de commented 2 years ago

It was closed because it wasn't active for long. See https://github.com/nextcloud/mail/issues/5988#issuecomment-1070904598

This still is relevant and would be a great addition to the mail app, making it more functional.

GretaD commented 2 years ago

Yes, its on our plan to work on this soon but no ETA yet

ChristophWurst commented 2 years ago

Primary goal of this ticket is to open PDF tickets. The others (Viewer) will come in the next step.