search

nextcloud / mail

💌 Mail app for Nextcloud
https://apps.nextcloud.com/apps/mail
GNU Affero General Public License v3.0
840 stars 260 forks source link

Doubly accepted event invitation handling #7227

Open ChristophWurst opened 2 years ago

ChristophWurst commented 2 years ago

Steps to reproduce

  1. Receive an event invite
  2. Accept it
  3. Accept it

Expected behavior

This is somehow handled

Actual behavior

https://github.com/nextcloud/mail/pull/6956#issuecomment-1231746598

Mail app version

2.0.0 beta 4

Mailserver or service

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database

No response

Additional info

@st3iny I'm transferring the old review comment. See if you can reproduce. If you can't close the ticket.

st3iny commented 1 year ago

I tried to reproduce it locally and it worked fine. Even if the accepted event is in another calendar (tried to reproduce your setup).

My early versions of the feature only checked the first/default calendar. Later, I implemented a check across all calendars and this likely fixed the issue.

However, handling of deleted events is weird. A user will see the invitation response buttons after deleting an already accepted/declined event and reacting again will fail because the uid is already taken.

This could be circumvented by also checking the trash and showing a special message like "You deleted the event". I'm not sure if it's worth the effort and should be prioritized (especially with https://github.com/nextcloud/mail/pull/7710 being merged).

ChristophWurst commented 3 weeks ago

Is there anything left to do?