nextcloud / mail

šŸ’Œ Mail app for Nextcloud
https://apps.nextcloud.com/apps/mail
GNU Affero General Public License v3.0
836 stars 259 forks source link

Missing Account Color Marker #7513

Open mat-m opened 1 year ago

mat-m commented 1 year ago

Steps to reproduce

  1. Open Mail app with 2 accounts
  2. Select Unified Inbox

Expected behavior

Color marker in front of every mail

Actual behavior

No Marker

Mail app version

2.0.3

Additional info

I saw the marker was removed with #6981, but the styling seems always here, as I could find

<style nonce="">.mail-message-account-color[data-v-433b9883]{position:absolute;left:0px;width:2px;height:69px;z-index:1}[...]</style>

in the header.

In #6981, there was no rationale for the removal. Can someone give one ? Since there is still some styling available, can we enable it back through Theming, if it can't be enabled by default or through a setting ?

Thank you

ChristophWurst commented 1 year ago

In #6981, there was no rationale for the removal. Can someone give one ?

I can't find a ticket but it was part of the "new design" for Mail 2.0 / Nextcloud 25. @nimishavijay @jancborchardt can you shed some light?

mat-m commented 1 year ago

I guess at first it didn't fit with the round borders, but we can set it between the avatar and the content.

mat-m commented 1 year ago

@nimishavijay @jancborchardt Typical use cases:

nimishavijay commented 1 year ago

The rounded corners did make it difficult to indicate the account color, but it was more about simplifying the interface by removing non-essential info. If you are using the unified inbox, it is unlikely that you are differentiating between the multiple emails you have and simply want a list of all messages. This was the idea behind removing it.

If we are reintroducing it, one solution is changing the color of the unread marker for unread emails in the unified inbox. For read emails it seems a bit more challenging because of the rounded corners šŸ¤”

mat-m commented 1 year ago

@nimishavijay I have many use cases:

Color can be between the sender icon and the text block. Quick try with 2px padding on app-content-list-item-icon and 2px border on list-item-content image

If you don't want it by default, just set it to 0px border, so people who want it can override the width in the Theming plugin ?

I also tried with backgrounds, but it's too much color (rgba color of account with 5% transparency) and will mess with hover and selected

mat-m commented 1 year ago

We can also imagine to have a permanent dot near the avatar, like: image

In the same spirit that you list both "from" and "to" mail adresses in the envelope head, we would have the sender and the mailbox's recipient

mat-m commented 1 year ago

Another use case: mail deleted too fast. It helps to know which trash we should search in

jancborchardt commented 1 year ago

@mat-m for the case of deleting mails too fast, we really need "undo" instead, so itā€™s a different solution. :) https://github.com/nextcloud/mail/issues/978

Regarding phishing protection, we automatically block images from all sources (unless specifically marked as trusted before), and we show the email of the sender in plaintext as well. We can certainly do some more improvements here, but a color marking for an account seems to be a not very obvious adjustment to protect from scams.

The reasoning about removing the color marking is:

mat-m commented 1 year ago

@jancborchardt : Answering quickly to your 3Ā items:

About scam/spam/phishing :

About colors for account:

We still have colors in front of accounts for now. Do you plan to also remove them ? I hope not. I actually do use K9-Mail and its color markers :wink: .Ā IĀ Ā even chose the colors myself in K-9 to know the match between account and color. For imported accounts in gmail, I actually defined some labels to identify them.Ā I'm that type of user.Ā 

I understand that my usage model may not be the heart of the target for NCĀ Mail, but it would be nice to have a way to keep colors and their productivity improvements they bring, at least through Theming Custom CSS.Ā Having colors items with a size of zero, or display:none, and being able to activate them for whoever wants it. My guess is that the users that finds value in colored accounts are mostly willing to get their hands dirty for this. To keep color visible in Message list, we can have it like K-9, a small vertical bar in front of the sender or the subject. My opinion is that the color is more useful in the messages list to differentiate them, but at least we can have it in the preview pane (in front of the thread subject, maybe) NaĆÆve question: About NCĀ Mail usage models, I'm curious to know whether you have personas to describe redline scenarios & behaviors within the app ?

More on my use cases of colors:

That's how my brain process information, and I was relieved to find a match in NCĀ Mail at first :smile: I don't expect you to find alternatives in NCĀ mail, but maybe it will provide other views on NCĀ Mail usage, and hopefully support my request to keep colors.

mat-m commented 1 year ago

@jancborchardt @nimishavijay : Last release of K-9 mail, moving to be Mozilla Thunderbird Mobile app, has even put the account name label with its color when reading the mail itself.

Below, matm is the name IĀ gave the mail account on which I received this spam:

image

marcotrevisan commented 11 months ago

Hi all, just adding my +1: please add the option to enable some color / marker / anything else in the unified view that makes it possible for the user to tell what account an incoming email belongs to. That way you'd have the best of both worlds: all emails sorted in a single folder and a hint on where they have arrived. Personally I don't agree on the assumption that when I use the unified view I don't need to know which account an email belongs to. I use unified folders all the day in Thunderbird with the "account" column enabled, I feel lost for not having it in NC mail.

Thanks!

mat-m commented 9 months ago

@jancborchardt: I just re-read your rationale on removing color, and realized I missed a point:

I don't know for iOS mail, but GMAIL app allows to set a label based on the account, so even if it's not native, you have an easy way to identify the belonging account for an email.

So another +1 to bring them back :)

mat-m commented 6 months ago

@nimishavijay : Can we consider to have a colored dot on the lower left part of the sender "icon" (horizontal symmetry from the important marker) ? image