nextcloud / maps

🌍🌏🌎 The whole world fits inside your cloud!
https://apps.nextcloud.com/apps/maps
GNU Affero General Public License v3.0
499 stars 88 forks source link

[Bug]: v29 compatibility #1218

Closed AndyScherzinger closed 5 months ago

AndyScherzinger commented 6 months ago

⚠️ This issue respects the following points: ⚠️

Bug description

maps app shows a blank page when opened on v20 beta1

Steps to reproduce

  1. Update a v28 instance to v29

Expected behavior

App is rendering

Installation method

Manual installation

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install of the server?

Updated to a major version (ex. 22.2.3 to 23.0.1)

Is this bug present after an update or on a fresh install of the app?

Updated from a minor version

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

Configuration report

No response

List of activated Apps

In theory a very long list, but due to the major release beta 1 phase expected to be an incompatibility

Nextcloud Signing status

No response

Nextcloud Logs

No response

Browser Console

No response

Additional info

No response

tflidd commented 5 months ago

I tried to use version 1.3.1 as untested app, but I get a white screen and the following details in the logs: {"reqId":"NaRj3ZShhtOXqlNMidM8","level":3,"time":"2024-04-18T08:12:08+00:00","remoteAddr":"ip","user":"user","app":"PHP","method":"GET","url":"/apps/maps/","message":"Cannot redeclare OCA\Maps\Controller\remove_utf8_bom() (previously declared in /usr/local/www/nextcloud-test/apps/maps/lib/Controller/PublicTracksController.php:53) at /usr/local/www/nextcloud-test/apps/maps/lib/Controller/TracksController.php#47","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:124.0) Gecko/20100101 Firefox/124.0","version":"29.0.0.17","data":{"app":"PHP"}}

tacruc commented 5 months ago

I have 5 more days correct?

tflidd commented 5 months ago

The final release for NC29 is the 24th of April (https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule), if you mean that. This would be a bit more than 5 days.

tacruc commented 5 months ago

Hi Folks, I just tried to reproduce the Issue: I tried v29 beta1 and git stable29 branch, with maps master and maps 1.3.1. The maps app loaded on my dev system in all cases.

Did the Issue resolve on your systems with any patch of the server?

AndyScherzinger commented 5 months ago

Issue still present I think, but currently I only get an HTTP 500 on 29.0.0 RC3 but I don't have access to the logs myself.

tacruc commented 5 months ago

Never mind, fund the issue. https://github.com/nextcloud/maps/pull/1244 should be running on NC29.

tacruc commented 5 months ago

Ok made it to the app store: https://apps.nextcloud.com/apps/maps/releases?platform=29#29

AndyScherzinger commented 5 months ago

Yet not released as a stable version ;)

2024-04-25 18_13_28-Maps - Apps - App Store - Nextcloud – Mozilla Firefox