nextcloud / maps

🌍🌏🌎 The whole world fits inside your cloud!
https://apps.nextcloud.com/apps/maps
GNU Affero General Public License v3.0
499 stars 88 forks source link

Scan photos of specific directory #1231

Open tetebueno opened 6 months ago

tetebueno commented 6 months ago

I've been getting memory exhaustion when scanning all photos collection on an initial load; trying to address #525 I made these changes and was able to scan each year/month directory of photos succesfully like this (the example is for the folder with photos of july '84):

$ docker exec -t -u www-data container-name php occ maps:scan-photos -vvv username Photos/1984/06

I didn't like the ifs all over the implementation, but it's something like a make it work approach. If I can get comments about it, we can make it better.

Cheers.

tacruc commented 6 months ago

Thanks for your contribution. Can you pass the path as optional argument? Do you need help to fix the DCO?

tetebueno commented 6 months ago

You are very welcome.

Done with DCO, thanks.

Is there anything else besides this so the path parameter is optional? I believe it already is since help command displays it like this: ... [<user_id> [<path>]].

tacruc commented 5 months ago

@tetebueno Do you think you will make the changes befor the NC29 release. Then I would wait with https://github.com/nextcloud/maps/pull/1244 to include this.

I'm sorry that it is on such short notice after not reviewing for a month. Just have to decide whether to wait or not.