nextcloud / maps

🌍🌏🌎 The whole world fits inside your cloud!
https://apps.nextcloud.com/apps/maps
GNU Affero General Public License v3.0
504 stars 89 forks source link

[Bug]: `Link to map` to a custom map failed if the custom map already have another linked favorite, unless manually edit `.favorites_share.json` #1288

Open amalgame21 opened 4 months ago

amalgame21 commented 4 months ago

⚠️ This issue respects the following points: ⚠️

Bug description

If a custom map already have a linked favorite, Link to map on a second favorite to that custom map will failed, unless manually edit .favorites_share.json to add the second link.

Steps to reproduce

  1. Create custom map named CUSTOM MAP
  2. On Default map, create a favorite point named 1 with category A
  3. On Default map, create a favorite point named 2 with category B
  4. On Default map, in My favorite menu A, click on 3-dot, then click Create share link
  5. On Default map, in My favorite menu B, click on 3-dot, then click Create share link
  6. On Default map, in My favorite menu A, click on 3-dot, then click Link to map, choose /Maps/CUSTOM MAP folder
  7. Message: Favorite category linked to map CUSTOM MAP
  8. On Default map, in My favorite menu B, click on 3-dot, then click Link to map, choose /Maps/CUSTOM MAP folder
  9. Message: Failed to link Favorite category to map CUSTOM MAP

Expected behavior

Message: Favorite category linked to map CUSTOM MAP for favorite category B

Now the work around is manually editing the .favorites_share.json to add the favorites.

We cannot share Default map to others, we can only share one of the Default maps favorite to others (by link). But we can share a CUSTOM MAP to others (by link/ by accounts, with view only permission), so when this bug is resolved, I can link the whole Default map to CUSTOM MAP and share it to other accounts.

Installation method

Other

Operating system

Other

PHP engine version

PHP 8.1

Web server

Nginx

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install of the server?

None

Is this bug present after an update or on a fresh install of the app?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

Configuration report

No response

List of activated Apps

Enabled:
  - activity: 2.21.1
  - calendar: 4.7.6
  - circles: 29.0.0-dev
  - cloud_federation_api: 1.12.0
  - comments: 1.19.0
  - contacts: 6.0.0
  - contactsinteraction: 1.10.0
  - dashboard: 7.9.0
  - dav: 1.30.1
  - end_to_end_encryption: 1.15.2
  - federatedfilesharing: 1.19.0
  - federation: 1.19.0
  - files: 2.1.0
  - files_downloadlimit: 2.0.0
  - files_pdfviewer: 2.10.0
  - files_reminders: 1.2.0
  - files_sharing: 1.21.0
  - files_trashbin: 1.19.0
  - files_versions: 1.22.0
  - firstrunwizard: 2.18.0
  - groupfolders: 17.0.0
  - logreader: 2.14.0
  - lookup_server_connector: 1.17.0
  - maps: 1.4.0
  - memories: 7.3.1
  - nextcloud_announcements: 1.18.0
  - notifications: 2.17.0
  - oauth2: 1.17.0
  - onlyoffice: 9.2.2
  - password_policy: 1.19.0
  - photos: 2.5.0
  - previewgenerator: 5.5.0
  - privacy: 1.13.0
  - provisioning_api: 1.19.0
  - recommendations: 2.1.0
  - related_resources: 1.4.0
  - serverinfo: 1.19.0
  - settings: 1.12.0
  - sharebymail: 1.19.0
  - support: 1.12.0
  - survey_client: 1.17.0
  - systemtags: 1.19.0
  - tasks: 0.16.0
  - text: 3.10.0
  - theming: 2.4.0
  - twofactor_backupcodes: 1.18.0
  - twofactor_webauthn: 1.4.0
  - updatenotification: 1.19.1
  - user_status: 1.9.0
  - viewer: 2.3.0
  - weather_status: 1.9.0
  - workflowengine: 2.11.0

Nextcloud Signing status

No response

Nextcloud Logs

No response

Browser Console

No response

Additional info

No response