search

nextcloud / maps

🌍🌏🌎 The whole world fits inside your cloud!
https://apps.nextcloud.com/apps/maps
GNU Affero General Public License v3.0
504 stars 88 forks source link

Support Nextcloud 30, update CSP header #1336

Closed Ma27 closed 2 weeks ago

Ma27 commented 1 month ago

Closes #1333 It probably makes most sense to review this commit-by-commit.

cc @come-nc @susnux @tacruc

Ma27 commented 1 month ago

Btw I've seen that the CI failed because of a missing Signed-off-by, will fix it up on the next iteration.

AndyScherzinger commented 1 month ago

cc @julien-nc I guess

tacruc commented 3 weeks ago

Hi @Ma27, Thanks a lot for your contribution I appreciate it a lot. Unfortunately I'm currently quite busy. Right now I'm sitting in a train and wanted to use the time to update and merge this. Unfortunately my laptop run out of battery and the plugs are not working. So I'm stuck with my phone.

Could you update the Test workflow such that the tests are run on NC30? https://github.com/nextcloud/maps/blob/master/.github/workflows/test.yml

Ma27 commented 3 weeks ago

Hi @tacruc! No worries at all!

Pushed a commit that does that. Not sure if it's completely correct though, I usually work with other CI systems :upside_down_face: However, I think you should be able to push to my fork's branch as well, right?

tacruc commented 2 weeks ago

Thanks a lot. In theory I should be able to push to your branch. In practice I didn't find a good git client for Android. Do you know one?

Can you remove v28 and v29 from testing and make the DCO, happy? I think then we can go for a merge.

Ma27 commented 2 weeks ago

Done.

tacruc commented 2 weeks ago

@Ma27, there is a nightly build with your PR https://apps.nextcloud.com/apps/maps