nextcloud / maps

🌍🌏🌎 The whole world fits inside your cloud!
https://apps.nextcloud.com/apps/maps
GNU Affero General Public License v3.0
504 stars 89 forks source link

[Bug]: UI for JSON (Google Takeout) Favorites Import missing #1342

Open thisisjoesGH opened 4 weeks ago

thisisjoesGH commented 4 weeks ago

⚠️ This issue respects the following points: ⚠️

Bug description

The ability to import favorites from Google Takeout data was added in #338, but the original UI it used appears to have been removed in 64a87881291276180c4d04f803d64c9712a18ffe. I am unable to find any way in the current UI to import favorites. The only current visible "import" feature is the device import which does not apparently support JSON files, the file picker it shows says:

Import devices from gpx (Nextcloud Maps) or kml/kmz (Google Timeline) file

Related: #1205

Favorites sidebar context menu: Image Favorites category context menu: Image

Steps to reproduce

  1. Install Nextcloud Maps
  2. Attempt to import saved locations from Google Maps from a JSON file downloaded through Google Takeout
  3. Find no usable import option

Expected behavior

Present user with option to import JSON files from Google Takeout somewhere in the UI

Installation method

Official SNAP package

Operating system

Other

PHP engine version

Other

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install of the server?

None

Is this bug present after an update or on a fresh install of the app?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

Configuration report

{ "system": { "apps_paths": [ { "path": "\/snap\/nextcloud\/current\/htdocs\/apps", "url": "\/apps", "writable": false }, { "path": "\/var\/snap\/nextcloud\/current\/nextcloud\/extra-apps", "url": "\/extra-apps", "writable": true } ], "supportedDatabases": [ "mysql" ], "memcache.locking": "\OC\Memcache\Redis", "memcache.local": "\OC\Memcache\Redis", "redis": { "host": "REMOVED SENSITIVE VALUE", "port": 0 }, "passwordsalt": "REMOVED SENSITIVE VALUE", "secret": "REMOVED SENSITIVE VALUE", "trusteddomains": [ "REMOVED SENSITIVE VALUE", "REMOVED SENSITIVE VALUE", "localhost" ], "datadirectory": "REMOVED SENSITIVE VALUE", "dbtype": "mysql", "version": "28.0.11.1", "overwrite.cli.url": "REMOVED SENSITIVE VALUE", "dbname": "REMOVED SENSITIVE VALUE", "dbhost": "REMOVED SENSITIVE VALUE", "dbport": "", "dbtableprefix": "oc", "mysql.utf8mb4": true, "dbuser": "REMOVED SENSITIVE VALUE", "dbpassword": "REMOVED SENSITIVE VALUE", "installed": true, "instanceid": "REMOVED SENSITIVE VALUE", "mail_smtpmode": "smtp", "mail_sendmailmode": "smtp", "mail_smtphost": "REMOVED SENSITIVE VALUE", "mail_domain": "REMOVED SENSITIVE VALUE", "loglevel": 0, "maintenance": false, "twofactor_enforced": "false", "twofactor_enforced_groups": [], "twofactor_enforced_excluded_groups": [], "mail_from_address": "REMOVED SENSITIVE VALUE", "mail_smtpsecure": "tls", "mail_smtpport": "587", "app_install_overwrite": [ "files_accesscontrol", "bookmarks_fulltextsearch", "files_downloadactivity" ], "theme": "", "has_rebuilt_cache": true, "mail_smtpauthtype": "PLAIN", "mail_smtpauth": 1, "mail_smtpname": "REMOVED SENSITIVE VALUE", "mail_smtppassword": "REMOVED SENSITIVE VALUE", "encryption.legacy_format_support": true, "encryption.key_storage_migrated": false, "encryption.legacy_format_support=false": "", "memories.exiftool": "\/var\/snap\/nextcloud\/44703\/nextcloud\/extra-apps\/memories\/bin-ext\/exiftool-amd64-glibc", "memories.vod.path": "\/var\/snap\/nextcloud\/44703\/nextcloud\/extra-apps\/memories\/bin-ext\/go-vod-amd64", "preview_max_x": 2048, "preview_max_y": 2048, "memories.db.triggers.fcu": true, "ldapProviderFactory": "OCA\User_LDAP\LDAPProviderFactory", "enforce_theme": "", "maintenance_window_start": 1 } }

List of activated Apps

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Browser Console

No response

Additional info

PHP engine version: 8.2 as per the Nextcloud Snap

Thanks for your work on the Nextcloud Maps app!

TheRaven500 commented 3 hours ago

It is not only "import" what is missing "delete" is also missing for favorites.