search

nextcloud / maps

🌍🌏🌎 The whole world fits inside your cloud!
https://apps.nextcloud.com/apps/maps
GNU Affero General Public License v3.0
490 stars 88 forks source link

Maps is unable to scan picture location when encryption is enabled. #549

Open peterablehmann opened 3 years ago

peterablehmann commented 3 years ago

In my Nextcloud Instance the Maps app does not display my Images. When I try to rescan Images via occ following occurs:

root@h2917249:~# nextcloud.occ maps:scan-photos Encryption is enabled. Aborted.

tacruc commented 3 years ago

Wouldn't it be scary, if our app could extract coordinates out of encrypted pictures?

peterablehmann commented 3 years ago

Yes but I would expect it to work for the user that's logged in. And that's not working.

simbelmas commented 3 years ago

The "encryption" is not precise nextcloud context. Two encryption types can be used:

End to end encryption

When using end to end encryption, server cannot decrypt file, which is wanted. There is no risk about trying to index them as the only thing the app will find is a file with unknown content.

Server side encryption

As the app is part of nextcloud and the server can decrypt all users files to display them like in files app, i think this is not as scary as it seems. In addition, app only shows connected user data.

Is it possible to let the app index files readable on server side and skip end-to-end encrypted ones?

marekful commented 2 years ago

Can we have an update on this? Maybe it's fixed in v23 and Maps can read geotags of photos when when server-side encryption is used?

softcoder commented 2 years ago

This cant be the only plugin, I mean the gpxpod app reads track files on encrypted servers, can we get this fixed?

https://gitlab.com/eneiluj/gpxpod-oc

softcoder commented 2 years ago

FYI I played with the code and disabling the encryption check makes everything work fine, I am able to rescan both photos and tracks!

gwenl commented 1 year ago

It seems photo scanning is disabled altogether when server encryption is enabled, even when there are photos on an unencrypted read-only external storage. IMO the app should at least try scanning those.

nils-one commented 1 year ago

FYI I played with the code and disabling the encryption check makes everything work fine, I am able to rescan both photos and tracks!

Can you give a hint where this check takes places? Just to save some time for someone who also wants to play with this.

peterablehmann commented 1 year ago

Personally, this issue doesn't apply to me anymore. My instance just scans as supposed with server side encryption enabled.

jkhsjdhjs commented 1 year ago

The issue still applies to me with nextcloud 26.0 and server-side encryption enabled.

EDIT: Also with 27.0.