[Bug]: favorite gets removed when applying a category

mortee commented 1 year ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] Maps app is up to date. See Maintenance and Release Schedule for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

I can add a favorite, give it a name, and apply my changes. But when I change the category and hit OK, the favorite just goes away.

Steps to reproduce

Create favorite
Open in sidebar
Change category
hit OK
it disappears

Expected behavior

The favorite should stay there, with the new category.

Installation method

Official Docker image

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.0

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install of the server?

Updated from a minor version (ex. 22.2.3 to 22.2.4)

Is this bug present after an update or on a fresh install of the app?

Updated from a minor version

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

[X] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

No response

List of activated Apps

Enabled:
  - accessibility: 1.10.0
  - activity: 2.16.0
  - analytics: 4.4.0
  - calendar: 3.5.0
  - circles: 24.0.1
  - cloud_federation_api: 1.7.0
  - comments: 1.14.0
  - contacts: 4.2.1
  - contactsinteraction: 1.5.0
  - cospend: 1.4.10
  - dashboard: 7.4.0
  - dav: 1.22.0
  - deck: 1.7.1
  - external: 4.0.0
  - federatedfilesharing: 1.14.0
  - federation: 1.14.0
  - files: 1.19.0
  - files_automatedtagging: 1.14.0
  - files_external: 1.16.1
  - files_markdown: 2.3.6
  - files_pdfviewer: 2.5.0
  - files_rightclick: 1.3.0
  - files_sharing: 1.16.2
  - files_texteditor: 2.14.0
  - files_trashbin: 1.14.0
  - files_versions: 1.17.0
  - files_videoplayer: 1.13.0
  - firstrunwizard: 2.13.0
  - flow_notifications: 1.4.0
  - logreader: 2.9.0
  - lookup_server_connector: 1.12.0
  - maps: 0.2.1
  - nextcloud_announcements: 1.13.0
  - notes: 4.5.1
  - notifications: 2.12.1
  - oauth2: 1.12.0
  - onlyoffice: 7.5.4
  - password_policy: 1.14.0
  - phonetrack: 0.7.0
  - photos: 1.6.0
  - previewgenerator: 5.0.0
  - privacy: 1.8.0
  - provisioning_api: 1.14.0
  - recommendations: 1.3.0
  - serverinfo: 1.14.0
  - settings: 1.6.0
  - sharebymail: 1.14.0
  - spreed: 14.0.5
  - support: 1.7.0
  - survey_client: 1.12.0
  - systemtags: 1.14.0
  - tasks: 0.14.4
  - text: 3.5.1
  - theming: 1.15.0
  - twofactor_backupcodes: 1.13.0
  - twofactor_totp: 6.4.0
  - updatenotification: 1.14.0
  - user_status: 1.4.0
  - viewer: 1.8.0
  - weather_status: 1.4.0
  - workflow_ocr: 1.24.4
  - workflowengine: 2.6.0
Disabled:
  - admin_audit
  - duplicatefinder: 0.0.13
  - encryption
  - files_mindmap: 0.0.26
  - notify_push: 0.4.0
  - passwords: 2022.3.20
  - user_ldap
  - workflow_pdf_converter: 1.8.0
  - workflow_script: 1.8.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Browser Console

No response

Additional info

No response

tacruc commented 1 year ago

I'm having problems to reproduce this. Can you please provide the Browser Console log and the nextcloud logs, when this happens. Additionally checking the

tacruc commented 1 year ago

Is it still happening for v0.2.5-2-nightly?

tacruc commented 1 year ago

Feel free to reopen if you can reproduce it in v0.2.5

mortee commented 1 year ago

I'm sorry, I've been really distracted lately, so I didn't test this nowadays. It happens on v0.2.4. If it happens on the next release too, I'll reopen.

mortee commented 1 year ago

Now I gave it a go, NC 25, Maps 1.0.0, updated Firefox. The issue still persists: if I try to change the category, nothing happens when I click on the new category in the pop-up menu. When I click outside the menu, then the new category is displayed in the sidebar, but it's not reflected on the pop-up over the star on the map. When I click OK in the sidebar, the favorite disappears from the map. Also, the single left-click menu stops appearing afterwards until I reload the page.

I might not be able to reopen this ticket.

mortee commented 1 year ago

Also as a side note: is there a substantial reason why only a single category is supported for favorites? It would be sooo convenient to be able to assign multiple ones at once.

tacruc commented 1 year ago

It would have some implications if there would be more then one. (probably nothing unsolvable but one would need to think about it). Like one category is shown and the other is disabled is the favorite shown or disabled? Similar things happen when sharing categories, especially as the permission are then given by the category, and of there is more then one they must be merged somehow.

mortee commented 1 year ago

I didn't even know I could share favorite catagories. When it comes to my common logic, display and sharing both should work on an includes basis: when a favorite is tagged with a category I wanna display or share, then include it.

E.g. I want my favorite bar to be shown when I'm looking for either restaurants or bars.

mortee commented 1 year ago

Now I gave it a go, NC 25, Maps 1.0.0, updated Firefox. The issue still persists

Just upgraded to NC 26, same results.

tacruc commented 1 year ago

Can you check the browser console and the network log?

mortee commented 1 year ago

Apparently, this is the relevant part:

Error while fetching an original source: can't assign to property "metadata" on "request failed with status 404": not an object
Source URL: <unknown> 3
jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 4 globals.js:59:15
A MouseEvent.mozPressure elavult. Használja helyette a PointerEvent.pressure tulajdonságot. leaflet-src.js:26:20
jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 4 globals.js:59:15
GEThttps://<mydomain>/apps/maps/noIcon
[HTTP/2 404 Not Found 436ms]

jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 4 globals.js:59:15
You need to fill either the text or the ariaLabel props in the button component. 
Object { text: undefined, ariaLabel: null }

Object { _uid: 88, _isVue: true, __v_skip: true, _scope: {…}, "$options": {…}, _renderProxy: {…}, _self: {…}, "$parent": {…}, "$root": {…}, "$children": [], … }
NcActions.js:2:2436
You need to fill either the text or the ariaLabel props in the button component. 
Object { text: undefined, ariaLabel: null }

Object { _uid: 88, _isVue: true, __v_skip: true, _scope: {…}, "$options": {…}, _renderProxy: {…}, _self: {…}, "$parent": {…}, "$root": {…}, "$children": [], … }
NcActions.js:2:2436
Error while fetching an original source: can't assign to property "metadata" on "request failed with status 404": not an object
Source URL: <unknown> 7
Error while fetching an original source: can't assign to property "metadata" on "request failed with status 404": not an object
Source URL: <unknown> 4
jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 4 globals.js:59:15
You need to fill either the text or the ariaLabel props in the button component. 
Object { text: undefined, ariaLabel: null }

Object { _uid: 88, _isVue: true, __v_skip: true, _scope: {…}, "$options": {…}, _renderProxy: {…}, _self: {…}, "$parent": {…}, "$root": {…}, "$children": [], … }
NcActions.js:2:2436
GEThttps://<mydomain>/svg/core/actions/star?color=000000
[HTTP/2 404 Not Found 390ms]

jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 4 globals.js:59:15
files:sidebar:opened App.vue:726
You need to fill either the text or the ariaLabel props in the button component. 
Object { text: undefined, ariaLabel: null }

Object { _uid: 88, _isVue: true, __v_skip: true, _scope: {…}, "$options": {…}, _renderProxy: {…}, _self: {…}, "$parent": {…}, "$root": {…}, "$children": [], … }
NcActions.js:2:2436
You need to fill either the text or the ariaLabel props in the button component. 
Object { text: undefined, ariaLabel: null }

Object { _uid: 88, _isVue: true, __v_skip: true, _scope: {…}, "$options": {…}, _renderProxy: {…}, _self: {…}, "$parent": {…}, "$root": {…}, "$children": [], … }
NcActions.js:2:2436

kép

mortee commented 1 year ago

Updated to Maps 1.0.2, same result.

Stephan2612 commented 4 months ago

Hi everyone, no idea if anyone else needs it, but I found a solution for myself because I've had this problem for a long time. Long story short: delete /Maps from the cloud.

Long version:

I backed up the folder /Maps to another location (in the cloud) and then deleted it...
I have uninstalled the app, reinstalled it....
I deleted tables from the database.... Then reinstalled the app.... Nothing helped.
I created a new cloud user: there it worked as it should!!!

In the nextcloud.log I found a hint that the app wants to use data from the backed up folder (on his new place) and was having a problem with it ("Failed to open stream") Only the completely deleting of all /Maps from the cloud, including all content, brought a functioning app. But be careful when deleting if you have important data. (In my case there were only corpses of the folders that were newly created and then disappeared. So nothing important yet.)

mortee commented 4 months ago

In the meantime, it became apparent that in certain cases, the issue might be due to the fact that the category which I switch the favorite over to is hidden, thus when it is applied, it immediately gets hidden.

I would prefer this not to happen, either by never hiding a favorite that is being edited, or better yet, don't hide any favorite due to category change until the next refresh.

nextcloud / maps