nextcloud / neon

A framework for building convergent cross-platform Nextcloud clients using Flutter.
Other
121 stars 29 forks source link

Support theme from branding #1093

Open Leptopoda opened 10 months ago

Leptopoda commented 10 months ago

1064 changed the colorscheme handling and we no longer use the theme provided by the app, always falling back to the NC blue.

    colorScheme ??= ColorScheme.fromSeed(
      seedColor: NcColors.primary,
      brightness: brightness,
    );
provokateurin commented 10 months ago

Wouldn't the branding rather disable the whole device and Nextcloud theme thing and just set the whole color scheme?

Leptopoda commented 10 months ago

Makes sense. We discussed this at the conference and track it in #789.

provokateurin commented 10 months ago

Should we then remove the color argument and later add the whole color scheme?

Leptopoda commented 10 months ago

I don't think immediate action is needed so we can just wait for the branding restructures. But we can it to the neon milestore