search

nextcloud / neon

A framework for building convergent cross-platform Nextcloud clients using Flutter.
Other
122 stars 29 forks source link

Wrong semantic label for drawer icons #2273

Closed Leptopoda closed 2 weeks ago

Leptopoda commented 1 month ago

https://github.com/nextcloud/neon/blob/4aa7f63ee7f8956a12d4c9ab093689251cb24cff/packages/neon_framework/lib/src/models/app_implementation.dart#L174

They are currently transcribed with Nextcloud logo which is wrong.

Apocalypse96 commented 1 month ago

Hey!! @Leptopoda I would love to solve this issue

provokateurin commented 1 month ago

Go for it :)

provokateurin commented 3 weeks ago

Shouldn't this rather be excluded from the semantics as it doesn't convey any meaning if you can't see it? It adds no value if a screenreader reads the label out loud.

Leptopoda commented 3 weeks ago

You're right. The text label will already be read