search

nextcloud / neon

A framework for building convergent cross-platform Nextcloud clients using Flutter.
Other
129 stars 31 forks source link

fix(nextcloud): Use correct WebDAV namespaces for oc:checksum, oc:share-type and oc:tags #2431

Closed provokateurin closed 2 months ago

provokateurin commented 2 months ago

Fixes https://github.com/nextcloud/neon/issues/2410

Just some stupid copy-pasta. To be fair the code in that file is not really readable because of all the annotations, fields and parameters...

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 27.21%. Comparing base (1d5e7de) to head (63330c5). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
.../nextcloud/lib/src/api/webdav/models/webdav.g.dart 44.44% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2431 +/- ## ========================================== + Coverage 27.19% 27.21% +0.01% ========================================== Files 370 370 Lines 136665 136663 -2 ========================================== + Hits 37163 37188 +25 + Misses 99502 99475 -27 ``` | [Flag](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [account_repository](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.64% <ø> (ø)` | | | | [cookie_store](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | Carriedforward from [1d5e7de](https://app.codecov.io/gh/nextcloud/neon/commit/1d5e7defd198e31fb8e518a2dbbe41f6ec850d8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dashboard_app](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | | | [dynamite](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `31.08% <ø> (ø)` | | Carriedforward from [1d5e7de](https://app.codecov.io/gh/nextcloud/neon/commit/1d5e7defd198e31fb8e518a2dbbe41f6ec850d8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dynamite_end_to_end_test](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `61.84% <ø> (ø)` | | Carriedforward from [1d5e7de](https://app.codecov.io/gh/nextcloud/neon/commit/1d5e7defd198e31fb8e518a2dbbe41f6ec850d8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dynamite_runtime](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `85.40% <ø> (ø)` | | Carriedforward from [1d5e7de](https://app.codecov.io/gh/nextcloud/neon/commit/1d5e7defd198e31fb8e518a2dbbe41f6ec850d8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_dashboard](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | Carriedforward from [1d5e7de](https://app.codecov.io/gh/nextcloud/neon/commit/1d5e7defd198e31fb8e518a2dbbe41f6ec850d8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_framework](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `43.55% <ø> (ø)` | | | | [neon_http_client](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `93.28% <ø> (ø)` | | | | [neon_notifications](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | Carriedforward from [1d5e7de](https://app.codecov.io/gh/nextcloud/neon/commit/1d5e7defd198e31fb8e518a2dbbe41f6ec850d8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_talk](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.45% <ø> (ø)` | | Carriedforward from [1d5e7de](https://app.codecov.io/gh/nextcloud/neon/commit/1d5e7defd198e31fb8e518a2dbbe41f6ec850d8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [nextcloud](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `23.26% <44.44%> (+0.02%)` | :arrow_up: | | | [notifications_app](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | | | [sort_box](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `90.90% <ø> (ø)` | | Carriedforward from [1d5e7de](https://app.codecov.io/gh/nextcloud/neon/commit/1d5e7defd198e31fb8e518a2dbbe41f6ec850d8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [talk_app](https://app.codecov.io/gh/nextcloud/neon/pull/2431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.09% <ø> (ø)` | | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) to find out more. | [Files with missing lines](https://app.codecov.io/gh/nextcloud/neon/pull/2431?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [...es/nextcloud/lib/src/api/webdav/models/webdav.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2431?src=pr&el=tree&filepath=packages%2Fnextcloud%2Flib%2Fsrc%2Fapi%2Fwebdav%2Fmodels%2Fwebdav.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmV4dGNsb3VkL2xpYi9zcmMvYXBpL3dlYmRhdi9tb2RlbHMvd2ViZGF2LmRhcnQ=) | `86.20% <ø> (+6.89%)` | :arrow_up: | | [.../nextcloud/lib/src/api/webdav/models/webdav.g.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2431?src=pr&el=tree&filepath=packages%2Fnextcloud%2Flib%2Fsrc%2Fapi%2Fwebdav%2Fmodels%2Fwebdav.g.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmV4dGNsb3VkL2xpYi9zcmMvYXBpL3dlYmRhdi9tb2RlbHMvd2ViZGF2LmcuZGFydA==) | `22.04% <44.44%> (+2.93%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/nextcloud/neon/pull/2431/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud)
Leptopoda commented 2 months ago

Can we add a test?

provokateurin commented 2 months ago

Done

Leptopoda commented 2 months ago

I'd rather have a separate test case for the checksum, tags and share. Therefore when one fails it's easier to identify the root cause.

Please also make a separate PR for the checksum commit (4bed78d012f4c51bda9f3ef11c04056b665416d3) as I'd like to discuss something specific to that without blocking this fix.