search

nextcloud / neon

A framework for building convergent cross-platform Nextcloud clients using Flutter.
Other
129 stars 31 forks source link

fix(dynamite): Escape wireNames #2443

Closed provokateurin closed 2 months ago

provokateurin commented 2 months ago

New field in Nextcloud 30 starts with a $

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 27.20%. Comparing base (81606fa) to head (5915c57). Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...mite_end_to_end_test/lib/interfaces.openapi.g.dart 18.75% 13 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2443 +/- ## ========================================== - Coverage 27.21% 27.20% -0.01% ========================================== Files 370 369 -1 Lines 136663 136676 +13 ========================================== + Hits 37188 37189 +1 - Misses 99475 99487 +12 ``` | [Flag](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [account_repository](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.64% <ø> (ø)` | | | | [cookie_store](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | Carriedforward from [81606fa](https://app.codecov.io/gh/nextcloud/neon/commit/81606fa86a886887a83d3c21dc623a0dcf2f60bd?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dashboard_app](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | | | [dynamite](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `31.08% <ø> (ø)` | | | | [dynamite_end_to_end_test](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `61.69% <18.75%> (-0.15%)` | :arrow_down: | | | [dynamite_runtime](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `85.40% <ø> (ø)` | | Carriedforward from [81606fa](https://app.codecov.io/gh/nextcloud/neon/commit/81606fa86a886887a83d3c21dc623a0dcf2f60bd?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_dashboard](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | Carriedforward from [81606fa](https://app.codecov.io/gh/nextcloud/neon/commit/81606fa86a886887a83d3c21dc623a0dcf2f60bd?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_framework](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `43.55% <ø> (ø)` | | | | [neon_http_client](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `93.28% <ø> (ø)` | | | | [neon_notifications](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | Carriedforward from [81606fa](https://app.codecov.io/gh/nextcloud/neon/commit/81606fa86a886887a83d3c21dc623a0dcf2f60bd?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_talk](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.45% <ø> (ø)` | | Carriedforward from [81606fa](https://app.codecov.io/gh/nextcloud/neon/commit/81606fa86a886887a83d3c21dc623a0dcf2f60bd?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [nextcloud](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `23.26% <ø> (+<0.01%)` | :arrow_up: | | | [notifications_app](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | | | [sort_box](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `90.90% <ø> (ø)` | | Carriedforward from [81606fa](https://app.codecov.io/gh/nextcloud/neon/commit/81606fa86a886887a83d3c21dc623a0dcf2f60bd?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [talk_app](https://app.codecov.io/gh/nextcloud/neon/pull/2443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.09% <ø> (-0.01%)` | :arrow_down: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) to find out more. | [Files with missing lines](https://app.codecov.io/gh/nextcloud/neon/pull/2443?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [...namite\_end\_to\_end\_test/lib/interfaces.openapi.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2443?src=pr&el=tree&filepath=packages%2Fdynamite%2Fpackages%2Fdynamite_end_to_end_test%2Flib%2Finterfaces.openapi.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvZHluYW1pdGUvcGFja2FnZXMvZHluYW1pdGVfZW5kX3RvX2VuZF90ZXN0L2xpYi9pbnRlcmZhY2VzLm9wZW5hcGkuZGFydA==) | `41.17% <ø> (ø)` | | | [...mite\_end\_to\_end\_test/lib/interfaces.openapi.g.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2443?src=pr&el=tree&filepath=packages%2Fdynamite%2Fpackages%2Fdynamite_end_to_end_test%2Flib%2Finterfaces.openapi.g.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvZHluYW1pdGUvcGFja2FnZXMvZHluYW1pdGVfZW5kX3RvX2VuZF90ZXN0L2xpYi9pbnRlcmZhY2VzLm9wZW5hcGkuZy5kYXJ0) | `29.35% <18.75%> (-2.61%)` | :arrow_down: |