search

nextcloud / neon

A framework for building convergent cross-platform Nextcloud clients using Flutter.
Other
123 stars 29 forks source link

chore(deps): update dependency flutter to v3.24.2 #2452

Closed provokateurin closed 3 weeks ago

provokateurin commented 1 month ago

Continuation of https://github.com/nextcloud/neon/pull/2399 Fixes https://github.com/nextcloud/neon/issues/2391

provokateurin commented 1 month ago

Ok flutter beta doesn't actually fix it for CI?!

provokateurin commented 3 weeks ago

Locally it works, let's see what CI has to say...

provokateurin commented 3 weeks ago

It seems to work finally!

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 29.92%. Comparing base (1265f22) to head (64ca2f1). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
packages/neon_framework/lib/src/pages/home.dart 0.00% 6 Missing :warning:
...kages/neon_framework/lib/src/pages/login_flow.dart 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2452 +/- ## ========================================== + Coverage 27.20% 29.92% +2.71% ========================================== Files 369 332 -37 Lines 136655 124414 -12241 ========================================== + Hits 37179 37231 +52 + Misses 99476 87183 -12293 ``` | [Flag](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [account_repository](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.64% <ø> (ø)` | | | | [cookie_store](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.48% <ø> (-0.52%)` | :arrow_down: | | | [dashboard_app](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | | | [dynamite](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `31.08% <ø> (ø)` | | | | [dynamite_end_to_end_test](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `61.69% <ø> (ø)` | | | | [dynamite_runtime](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `85.40% <ø> (ø)` | | | | [neon_dashboard](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | Carriedforward from [1265f22](https://app.codecov.io/gh/nextcloud/neon/commit/1265f2286ce07db274e473d3f5f44a53eb5b25d0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_framework](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `43.65% <0.00%> (-0.04%)` | :arrow_down: | | | [neon_http_client](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `93.28% <ø> (ø)` | | | | [neon_notifications](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | Carriedforward from [1265f22](https://app.codecov.io/gh/nextcloud/neon/commit/1265f2286ce07db274e473d3f5f44a53eb5b25d0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_talk](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.45% <ø> (ø)` | | Carriedforward from [1265f22](https://app.codecov.io/gh/nextcloud/neon/commit/1265f2286ce07db274e473d3f5f44a53eb5b25d0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [nextcloud](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `25.90% <ø> (+2.64%)` | :arrow_up: | | | [notifications_app](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | | | [sort_box](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `90.90% <ø> (ø)` | | | | [talk_app](https://app.codecov.io/gh/nextcloud/neon/pull/2452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.09% <100.00%> (+<0.01%)` | :arrow_up: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) to find out more. | [Files with missing lines](https://app.codecov.io/gh/nextcloud/neon/pull/2452?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [...s/neon\_framework/lib/src/utils/global\_options.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2452?src=pr&el=tree&filepath=packages%2Fneon_framework%2Flib%2Fsrc%2Futils%2Fglobal_options.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvbGliL3NyYy91dGlscy9nbG9iYWxfb3B0aW9ucy5kYXJ0) | `0.00% <ø> (ø)` | | | [...ackages/neon\_framework/lib/src/widgets/drawer.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2452?src=pr&el=tree&filepath=packages%2Fneon_framework%2Flib%2Fsrc%2Fwidgets%2Fdrawer.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvbGliL3NyYy93aWRnZXRzL2RyYXdlci5kYXJ0) | `62.96% <ø> (ø)` | | | [...ramework/packages/talk\_app/lib/src/pages/room.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2452?src=pr&el=tree&filepath=packages%2Fneon_framework%2Fpackages%2Ftalk_app%2Flib%2Fsrc%2Fpages%2Froom.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvcGFja2FnZXMvdGFsa19hcHAvbGliL3NyYy9wYWdlcy9yb29tLmRhcnQ=) | `100.00% <100.00%> (ø)` | | | [packages/neon\_framework/lib/src/pages/home.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2452?src=pr&el=tree&filepath=packages%2Fneon_framework%2Flib%2Fsrc%2Fpages%2Fhome.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvbGliL3NyYy9wYWdlcy9ob21lLmRhcnQ=) | `0.00% <0.00%> (ø)` | | | [...kages/neon\_framework/lib/src/pages/login\_flow.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2452?src=pr&el=tree&filepath=packages%2Fneon_framework%2Flib%2Fsrc%2Fpages%2Flogin_flow.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvbGliL3NyYy9wYWdlcy9sb2dpbl9mbG93LmRhcnQ=) | `0.00% <0.00%> (ø)` | | ... and [45 files with indirect coverage changes](https://app.codecov.io/gh/nextcloud/neon/pull/2452/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud)