search

nextcloud / neon

A framework for building convergent cross-platform Nextcloud clients using Flutter.
Other
123 stars 29 forks source link

feat(nextcloud): Implement WebDAV extended MKCOL #2455

Closed provokateurin closed 4 weeks ago

provokateurin commented 4 weeks ago

Closes https://github.com/nextcloud/neon/issues/512

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 65.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 29.89%. Comparing base (4ce78c1) to head (91752b3). Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
.../nextcloud/lib/src/api/webdav/models/webdav.g.dart 57.57% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2455 +/- ## ========================================== + Coverage 29.87% 29.89% +0.02% ========================================== Files 332 332 Lines 124330 124348 +18 ========================================== + Hits 37138 37171 +33 + Misses 87192 87177 -15 ``` | [Flag](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [account_repository](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.64% <ø> (ø)` | | | | [cookie_store](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | Carriedforward from [3282a80](https://app.codecov.io/gh/nextcloud/neon/commit/3282a80b4d4120b85520470693135b90a19e115d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dashboard_app](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | | | [dynamite](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `31.08% <ø> (ø)` | | Carriedforward from [3282a80](https://app.codecov.io/gh/nextcloud/neon/commit/3282a80b4d4120b85520470693135b90a19e115d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dynamite_end_to_end_test](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `61.85% <ø> (+0.15%)` | :arrow_up: | Carriedforward from [3282a80](https://app.codecov.io/gh/nextcloud/neon/commit/3282a80b4d4120b85520470693135b90a19e115d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dynamite_runtime](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `85.40% <ø> (ø)` | | Carriedforward from [3282a80](https://app.codecov.io/gh/nextcloud/neon/commit/3282a80b4d4120b85520470693135b90a19e115d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_dashboard](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | Carriedforward from [3282a80](https://app.codecov.io/gh/nextcloud/neon/commit/3282a80b4d4120b85520470693135b90a19e115d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_framework](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `43.55% <ø> (ø)` | | | | [neon_http_client](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `93.28% <ø> (ø)` | | | | [neon_notifications](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | Carriedforward from [3282a80](https://app.codecov.io/gh/nextcloud/neon/commit/3282a80b4d4120b85520470693135b90a19e115d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_talk](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.45% <ø> (ø)` | | Carriedforward from [3282a80](https://app.codecov.io/gh/nextcloud/neon/commit/3282a80b4d4120b85520470693135b90a19e115d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [nextcloud](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `25.90% <65.00%> (+0.02%)` | :arrow_up: | | | [notifications_app](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | | | [sort_box](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `90.90% <ø> (ø)` | | Carriedforward from [3282a80](https://app.codecov.io/gh/nextcloud/neon/commit/3282a80b4d4120b85520470693135b90a19e115d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [talk_app](https://app.codecov.io/gh/nextcloud/neon/pull/2455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.09% <ø> (ø)` | | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) to find out more. | [Files with missing lines](https://app.codecov.io/gh/nextcloud/neon/pull/2455?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [...es/nextcloud/lib/src/api/webdav/models/webdav.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2455?src=pr&el=tree&filepath=packages%2Fnextcloud%2Flib%2Fsrc%2Fapi%2Fwebdav%2Fmodels%2Fwebdav.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmV4dGNsb3VkL2xpYi9zcmMvYXBpL3dlYmRhdi9tb2RlbHMvd2ViZGF2LmRhcnQ=) | `86.66% <100.00%> (+0.45%)` | :arrow_up: | | [...es/nextcloud/lib/src/api/webdav/webdav\_client.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2455?src=pr&el=tree&filepath=packages%2Fnextcloud%2Flib%2Fsrc%2Fapi%2Fwebdav%2Fwebdav_client.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmV4dGNsb3VkL2xpYi9zcmMvYXBpL3dlYmRhdi93ZWJkYXZfY2xpZW50LmRhcnQ=) | `99.34% <100.00%> (ø)` | | | [.../nextcloud/lib/src/api/webdav/models/webdav.g.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2455?src=pr&el=tree&filepath=packages%2Fnextcloud%2Flib%2Fsrc%2Fapi%2Fwebdav%2Fmodels%2Fwebdav.g.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmV4dGNsb3VkL2xpYi9zcmMvYXBpL3dlYmRhdi9tb2RlbHMvd2ViZGF2LmcuZGFydA==) | `25.49% <57.57%> (+3.44%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/nextcloud/neon/pull/2455/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud)
provokateurin commented 4 weeks ago

I have no Idea what this is used for but the changes look sane

You can simply set props while creating resources (mostly directories). It saves you another request.