search

nextcloud / neon

A framework for building convergent cross-platform Nextcloud clients using Flutter.
Other
129 stars 31 forks source link

feat(tool,neon_framework): Update logo and use adaptive icons #2457

Closed provokateurin closed 2 months ago

provokateurin commented 2 months ago

Closes https://github.com/nextcloud/neon/issues/447

This was quite some work to get done, but I think it looks way better now: image image

It was not possible to split this into multiple commits as everything is coupled tightly.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.20%. Comparing base (91752b3) to head (65a8feb). Report is 14 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2457 +/- ## ========================================== - Coverage 29.89% 27.20% -2.69% ========================================== Files 332 369 +37 Lines 124348 136655 +12307 ========================================== + Hits 37171 37179 +8 - Misses 87177 99476 +12299 ``` | [Flag](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [account_repository](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.64% <ø> (ø)` | | | | [cookie_store](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | Carriedforward from [5c6b788](https://app.codecov.io/gh/nextcloud/neon/commit/5c6b7888535b7ab139fa4b067b23aaec8ca3792a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dashboard_app](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | | | [dynamite](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `31.08% <ø> (ø)` | | Carriedforward from [5c6b788](https://app.codecov.io/gh/nextcloud/neon/commit/5c6b7888535b7ab139fa4b067b23aaec8ca3792a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dynamite_end_to_end_test](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `61.69% <ø> (-0.16%)` | :arrow_down: | Carriedforward from [5c6b788](https://app.codecov.io/gh/nextcloud/neon/commit/5c6b7888535b7ab139fa4b067b23aaec8ca3792a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dynamite_runtime](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `85.40% <ø> (ø)` | | Carriedforward from [5c6b788](https://app.codecov.io/gh/nextcloud/neon/commit/5c6b7888535b7ab139fa4b067b23aaec8ca3792a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_dashboard](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | Carriedforward from [5c6b788](https://app.codecov.io/gh/nextcloud/neon/commit/5c6b7888535b7ab139fa4b067b23aaec8ca3792a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_framework](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `43.69% <ø> (+0.14%)` | :arrow_up: | | | [neon_http_client](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `93.28% <ø> (ø)` | | Carriedforward from [5c6b788](https://app.codecov.io/gh/nextcloud/neon/commit/5c6b7888535b7ab139fa4b067b23aaec8ca3792a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_notifications](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | Carriedforward from [5c6b788](https://app.codecov.io/gh/nextcloud/neon/commit/5c6b7888535b7ab139fa4b067b23aaec8ca3792a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_talk](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.45% <ø> (ø)` | | Carriedforward from [5c6b788](https://app.codecov.io/gh/nextcloud/neon/commit/5c6b7888535b7ab139fa4b067b23aaec8ca3792a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [nextcloud](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `23.26% <ø> (-2.65%)` | :arrow_down: | Carriedforward from [5c6b788](https://app.codecov.io/gh/nextcloud/neon/commit/5c6b7888535b7ab139fa4b067b23aaec8ca3792a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [notifications_app](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | | | [sort_box](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `90.90% <ø> (ø)` | | Carriedforward from [5c6b788](https://app.codecov.io/gh/nextcloud/neon/commit/5c6b7888535b7ab139fa4b067b23aaec8ca3792a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [talk_app](https://app.codecov.io/gh/nextcloud/neon/pull/2457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.09% <ø> (ø)` | | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) to find out more. [see 42 files with indirect coverage changes](https://app.codecov.io/gh/nextcloud/neon/pull/2457/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud)
provokateurin commented 2 months ago

Ok I will give it a try, but it is probably a lot harder than you'd think.

provokateurin commented 2 months ago

Works for adaptive icons: image As for the non-adaptive icons it doesn't work because inkscape doesn't work with CSS gradient: Ignoring unrecognized CSS property: background-image.

provokateurin commented 2 months ago

I just realized there are some mistakes...

Leptopoda commented 2 months ago

As for the non-adaptive icons it doesn't work because inkscape doesn't work with CSS gradient: Ignoring unrecognized CSS property: background-image.

This shouldn't be a problem. Adaptive icons are supported since api 26 (8.0) while our min sdk is currently api 24 (7.0) so this shouldn't really matter.

Thanks for the quick changes; I'll do a review once you got it fixed and I have a bit of time.

provokateurin commented 2 months ago

This shouldn't be a problem. Adaptive icons are supported since api 26 (8.0) while our min sdk is currently api 24 (7.0) so this shouldn't really matter.

I agree. I think everywhere else we also show the icon in blue with transparent background, so there we don't need the gradient either.

Thanks for the quick changes; I'll do a review once you got it fixed and I have a bit of time.

Done