search

nextcloud / neon

A framework for building convergent cross-platform Nextcloud clients using Flutter.
Other
123 stars 29 forks source link

refactor(neon_http_client): split into separate interceptor client package #2467

Closed Leptopoda closed 2 weeks ago

Leptopoda commented 3 weeks ago

Signed-off-by: Nikolas Rimikis leptopoda@users.noreply.github.com

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.95%. Comparing base (87a7a39) to head (47b3d61). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...r_http_client/lib/src/interceptor_http_client.dart 94.11% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2467 +/- ## ========================================== + Coverage 29.92% 29.95% +0.02% ========================================== Files 332 334 +2 Lines 124408 124453 +45 ========================================== + Hits 37225 37274 +49 + Misses 87183 87179 -4 ``` | [Flag](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [account_repository](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.64% <ø> (ø)` | | | | [cookie_store](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.48% <ø> (ø)` | | Carriedforward from [87a7a39](https://app.codecov.io/gh/nextcloud/neon/commit/87a7a39da54eee9226f5195a87a7059cc6adff66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dashboard_app](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | | | [dynamite](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `31.08% <ø> (ø)` | | Carriedforward from [87a7a39](https://app.codecov.io/gh/nextcloud/neon/commit/87a7a39da54eee9226f5195a87a7059cc6adff66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dynamite_end_to_end_test](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `61.69% <ø> (ø)` | | Carriedforward from [87a7a39](https://app.codecov.io/gh/nextcloud/neon/commit/87a7a39da54eee9226f5195a87a7059cc6adff66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dynamite_runtime](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `85.40% <ø> (ø)` | | Carriedforward from [87a7a39](https://app.codecov.io/gh/nextcloud/neon/commit/87a7a39da54eee9226f5195a87a7059cc6adff66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [interceptor_http_client](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `97.18% <94.11%> (?)` | | | | [neon_dashboard](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | Carriedforward from [87a7a39](https://app.codecov.io/gh/nextcloud/neon/commit/87a7a39da54eee9226f5195a87a7059cc6adff66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_framework](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `43.57% <ø> (ø)` | | | | [neon_http_client](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.69% <100.00%> (+3.49%)` | :arrow_up: | | | [neon_notifications](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | Carriedforward from [87a7a39](https://app.codecov.io/gh/nextcloud/neon/commit/87a7a39da54eee9226f5195a87a7059cc6adff66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_talk](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.45% <ø> (ø)` | | Carriedforward from [87a7a39](https://app.codecov.io/gh/nextcloud/neon/commit/87a7a39da54eee9226f5195a87a7059cc6adff66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [nextcloud](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `25.90% <ø> (ø)` | | | | [notifications_app](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | | | [sort_box](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `90.90% <ø> (ø)` | | Carriedforward from [87a7a39](https://app.codecov.io/gh/nextcloud/neon/commit/87a7a39da54eee9226f5195a87a7059cc6adff66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [talk_app](https://app.codecov.io/gh/nextcloud/neon/pull/2467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.09% <ø> (ø)` | | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) to find out more. | [Files with missing lines](https://app.codecov.io/gh/nextcloud/neon/pull/2467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [...lient/lib/src/interceptors/cookie\_interceptor.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2467?src=pr&el=tree&filepath=packages%2Finterceptor_http_client%2Flib%2Fsrc%2Finterceptors%2Fcookie_interceptor.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvaW50ZXJjZXB0b3JfaHR0cF9jbGllbnQvbGliL3NyYy9pbnRlcmNlcHRvcnMvY29va2llX2ludGVyY2VwdG9yLmRhcnQ=) | `100.00% <ø> (ø)` | | | [...rceptors/authorization\_throttling\_interceptor.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2467?src=pr&el=tree&filepath=packages%2Fneon_framework%2Fpackages%2Fneon_http_client%2Flib%2Fsrc%2Finterceptors%2Fauthorization_throttling_interceptor.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvcGFja2FnZXMvbmVvbl9odHRwX2NsaWVudC9saWIvc3JjL2ludGVyY2VwdG9ycy9hdXRob3JpemF0aW9uX3Rocm90dGxpbmdfaW50ZXJjZXB0b3IuZGFydA==) | `100.00% <ø> (ø)` | | | [.../lib/src/interceptors/base\_header\_interceptor.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2467?src=pr&el=tree&filepath=packages%2Fneon_framework%2Fpackages%2Fneon_http_client%2Flib%2Fsrc%2Finterceptors%2Fbase_header_interceptor.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvcGFja2FnZXMvbmVvbl9odHRwX2NsaWVudC9saWIvc3JjL2ludGVyY2VwdG9ycy9iYXNlX2hlYWRlcl9pbnRlcmNlcHRvci5kYXJ0) | `83.33% <ø> (ø)` | | | [...\_client/lib/src/interceptors/csrf\_interceptor.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2467?src=pr&el=tree&filepath=packages%2Fneon_framework%2Fpackages%2Fneon_http_client%2Flib%2Fsrc%2Finterceptors%2Fcsrf_interceptor.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvcGFja2FnZXMvbmVvbl9odHRwX2NsaWVudC9saWIvc3JjL2ludGVyY2VwdG9ycy9jc3JmX2ludGVyY2VwdG9yLmRhcnQ=) | `97.14% <ø> (ø)` | | | [...ges/neon\_http\_client/lib/src/neon\_http\_client.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2467?src=pr&el=tree&filepath=packages%2Fneon_framework%2Fpackages%2Fneon_http_client%2Flib%2Fsrc%2Fneon_http_client.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvcGFja2FnZXMvbmVvbl9odHRwX2NsaWVudC9saWIvc3JjL25lb25faHR0cF9jbGllbnQuZGFydA==) | `100.00% <100.00%> (+4.16%)` | :arrow_up: | | [...r\_http\_client/lib/src/interceptor\_http\_client.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2467?src=pr&el=tree&filepath=packages%2Finterceptor_http_client%2Flib%2Fsrc%2Finterceptor_http_client.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvaW50ZXJjZXB0b3JfaHR0cF9jbGllbnQvbGliL3NyYy9pbnRlcmNlcHRvcl9odHRwX2NsaWVudC5kYXJ0) | `94.11% <94.11%> (ø)` | |