search

nextcloud / neon

A framework for building convergent cross-platform Nextcloud clients using Flutter.
Other
123 stars 29 forks source link

fix(account_repository): Change active account after logging in with a new one #2493

Closed provokateurin closed 2 weeks ago

provokateurin commented 2 weeks ago

This is how it used to work before and it is a lot more intuitive to the user as they otherwise might think the account was not added properly.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 30.29%. Comparing base (ac7f659) to head (31aaa4d). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2493 +/- ## ======================================= Coverage 30.29% 30.29% ======================================= Files 352 352 Lines 124361 124361 ======================================= Hits 37672 37672 Misses 86689 86689 ``` | [Flag](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [account_repository](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `98.77% <100.00%> (ø)` | | | | [cookie_store](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.48% <ø> (ø)` | | Carriedforward from [ac7f659](https://app.codecov.io/gh/nextcloud/neon/commit/ac7f6590de76d1f6d909d6dc09984b8814f26d6d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dashboard_app](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | | | [dynamite](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `31.08% <ø> (ø)` | | Carriedforward from [ac7f659](https://app.codecov.io/gh/nextcloud/neon/commit/ac7f6590de76d1f6d909d6dc09984b8814f26d6d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dynamite_end_to_end_test](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `61.69% <ø> (ø)` | | Carriedforward from [ac7f659](https://app.codecov.io/gh/nextcloud/neon/commit/ac7f6590de76d1f6d909d6dc09984b8814f26d6d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dynamite_runtime](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `85.40% <ø> (ø)` | | Carriedforward from [ac7f659](https://app.codecov.io/gh/nextcloud/neon/commit/ac7f6590de76d1f6d909d6dc09984b8814f26d6d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_dashboard](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | Carriedforward from [ac7f659](https://app.codecov.io/gh/nextcloud/neon/commit/ac7f6590de76d1f6d909d6dc09984b8814f26d6d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_framework](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `57.10% <ø> (ø)` | | | | [neon_http_client](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.69% <ø> (ø)` | | Carriedforward from [ac7f659](https://app.codecov.io/gh/nextcloud/neon/commit/ac7f6590de76d1f6d909d6dc09984b8814f26d6d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_notifications](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | Carriedforward from [ac7f659](https://app.codecov.io/gh/nextcloud/neon/commit/ac7f6590de76d1f6d909d6dc09984b8814f26d6d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_talk](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.45% <ø> (ø)` | | Carriedforward from [ac7f659](https://app.codecov.io/gh/nextcloud/neon/commit/ac7f6590de76d1f6d909d6dc09984b8814f26d6d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [nextcloud](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `25.90% <ø> (ø)` | | Carriedforward from [ac7f659](https://app.codecov.io/gh/nextcloud/neon/commit/ac7f6590de76d1f6d909d6dc09984b8814f26d6d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [notifications_app](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | | | [sort_box](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `90.90% <ø> (ø)` | | Carriedforward from [ac7f659](https://app.codecov.io/gh/nextcloud/neon/commit/ac7f6590de76d1f6d909d6dc09984b8814f26d6d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [talk_app](https://app.codecov.io/gh/nextcloud/neon/pull/2493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.09% <ø> (ø)` | | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) to find out more. | [Files with missing lines](https://app.codecov.io/gh/nextcloud/neon/pull/2493?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [...account\_repository/lib/src/account\_repository.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2493?src=pr&el=tree&filepath=packages%2Fneon_framework%2Fpackages%2Faccount_repository%2Flib%2Fsrc%2Faccount_repository.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvcGFja2FnZXMvYWNjb3VudF9yZXBvc2l0b3J5L2xpYi9zcmMvYWNjb3VudF9yZXBvc2l0b3J5LmRhcnQ=) | `100.00% <100.00%> (ø)` | |