search

nextcloud / neon

A framework for building convergent cross-platform Nextcloud clients using Flutter.
Other
129 stars 31 forks source link

refactor(neon_framework): migrate to neon_storage #2529

Open Leptopoda opened 1 month ago

Leptopoda commented 1 month ago

Signed-off-by: Nikolas Rimikis leptopoda@users.noreply.github.com

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 74.21384% with 41 lines in your changes missing coverage. Please review.

Project coverage is 28.69%. Comparing base (29f6a4b) to head (b7d8a42). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../neon_framework/lib/src/storage/neon_cache_db.dart 0.00% 13 Missing :warning:
...es/account_repository/lib/src/account_storage.dart 85.52% 11 Missing :warning:
...s/neon_framework/lib/src/storage/neon_data_db.dart 0.00% 10 Missing :warning:
...eon_framework/lib/src/storage/storage_manager.dart 0.00% 6 Missing :warning:
...age/lib/src/storage/sqlite_cookie_persistence.dart 92.30% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2529 +/- ## ========================================== + Coverage 28.66% 28.69% +0.02% ========================================== Files 366 369 +3 Lines 136296 136370 +74 ========================================== + Hits 39076 39137 +61 - Misses 97220 97233 +13 ``` | [Flag](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [account_repository](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `95.92% <87.77%> (-2.85%)` | :arrow_down: | | | [cookie_store](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.48% <ø> (ø)` | | Carriedforward from [29f6a4b](https://app.codecov.io/gh/nextcloud/neon/commit/29f6a4bb2a6b293912f71b6d3ee1fe7438f51e3c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dashboard_app](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | | | [dynamite](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `31.05% <ø> (ø)` | | Carriedforward from [29f6a4b](https://app.codecov.io/gh/nextcloud/neon/commit/29f6a4bb2a6b293912f71b6d3ee1fe7438f51e3c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dynamite_end_to_end_test](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `61.69% <ø> (ø)` | | Carriedforward from [29f6a4b](https://app.codecov.io/gh/nextcloud/neon/commit/29f6a4bb2a6b293912f71b6d3ee1fe7438f51e3c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [dynamite_runtime](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `85.40% <ø> (ø)` | | Carriedforward from [29f6a4b](https://app.codecov.io/gh/nextcloud/neon/commit/29f6a4bb2a6b293912f71b6d3ee1fe7438f51e3c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [interceptor_http_client](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `97.18% <ø> (ø)` | | Carriedforward from [29f6a4b](https://app.codecov.io/gh/nextcloud/neon/commit/29f6a4bb2a6b293912f71b6d3ee1fe7438f51e3c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_dashboard](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `96.05% <ø> (ø)` | | Carriedforward from [29f6a4b](https://app.codecov.io/gh/nextcloud/neon/commit/29f6a4bb2a6b293912f71b6d3ee1fe7438f51e3c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_framework](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `57.02% <9.37%> (-2.18%)` | :arrow_down: | | | [neon_http_client](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `97.50% <ø> (ø)` | | Carriedforward from [29f6a4b](https://app.codecov.io/gh/nextcloud/neon/commit/29f6a4bb2a6b293912f71b6d3ee1fe7438f51e3c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_notifications](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `100.00% <ø> (ø)` | | Carriedforward from [29f6a4b](https://app.codecov.io/gh/nextcloud/neon/commit/29f6a4bb2a6b293912f71b6d3ee1fe7438f51e3c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [neon_storage](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `88.88% <97.29%> (-5.78%)` | :arrow_down: | | | [neon_talk](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `99.45% <ø> (ø)` | | Carriedforward from [29f6a4b](https://app.codecov.io/gh/nextcloud/neon/commit/29f6a4bb2a6b293912f71b6d3ee1fe7438f51e3c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [nextcloud](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `24.26% <ø> (ø)` | | Carriedforward from [29f6a4b](https://app.codecov.io/gh/nextcloud/neon/commit/29f6a4bb2a6b293912f71b6d3ee1fe7438f51e3c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [notifications_app](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `97.40% <ø> (ø)` | | | | [notifications_push_repository](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `98.59% <ø> (ø)` | | | | [sort_box](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `90.90% <ø> (ø)` | | Carriedforward from [29f6a4b](https://app.codecov.io/gh/nextcloud/neon/commit/29f6a4bb2a6b293912f71b6d3ee1fe7438f51e3c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | [talk_app](https://app.codecov.io/gh/nextcloud/neon/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `98.94% <ø> (ø)` | | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) to find out more. | [Files with missing lines](https://app.codecov.io/gh/nextcloud/neon/pull/2529?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [...ackages/neon\_framework/lib/src/blocs/accounts.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2529?src=pr&el=tree&filepath=packages%2Fneon_framework%2Flib%2Fsrc%2Fblocs%2Faccounts.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvbGliL3NyYy9ibG9jcy9hY2NvdW50cy5kYXJ0) | `0.00% <ø> (ø)` | | | [...ges/neon\_framework/lib/src/blocs/first\_launch.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2529?src=pr&el=tree&filepath=packages%2Fneon_framework%2Flib%2Fsrc%2Fblocs%2Ffirst_launch.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvbGliL3NyYy9ibG9jcy9maXJzdF9sYXVuY2guZGFydA==) | `0.00% <ø> (ø)` | | | [...n\_framework/lib/src/models/app\_implementation.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2529?src=pr&el=tree&filepath=packages%2Fneon_framework%2Flib%2Fsrc%2Fmodels%2Fapp_implementation.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvbGliL3NyYy9tb2RlbHMvYXBwX2ltcGxlbWVudGF0aW9uLmRhcnQ=) | `0.00% <ø> (ø)` | | | [...lib/src/settings/utils/settings\_export\_helper.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2529?src=pr&el=tree&filepath=packages%2Fneon_framework%2Flib%2Fsrc%2Fsettings%2Futils%2Fsettings_export_helper.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvbGliL3NyYy9zZXR0aW5ncy91dGlscy9zZXR0aW5nc19leHBvcnRfaGVscGVyLmRhcnQ=) | `100.00% <ø> (ø)` | | | [...neon\_framework/lib/src/storage/settings\_store.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2529?src=pr&el=tree&filepath=packages%2Fneon_framework%2Flib%2Fsrc%2Fstorage%2Fsettings_store.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvbGliL3NyYy9zdG9yYWdlL3NldHRpbmdzX3N0b3JlLmRhcnQ=) | `84.61% <ø> (ø)` | | | [...\_framework/lib/src/storage/single\_value\_store.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2529?src=pr&el=tree&filepath=packages%2Fneon_framework%2Flib%2Fsrc%2Fstorage%2Fsingle_value_store.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvbGliL3NyYy9zdG9yYWdlL3NpbmdsZV92YWx1ZV9zdG9yZS5kYXJ0) | `100.00% <ø> (ø)` | | | [packages/neon\_framework/lib/src/testing/mocks.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2529?src=pr&el=tree&filepath=packages%2Fneon_framework%2Flib%2Fsrc%2Ftesting%2Fmocks.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvbGliL3NyYy90ZXN0aW5nL21vY2tzLmRhcnQ=) | `91.66% <ø> (-0.65%)` | :arrow_down: | | [...s/neon\_framework/lib/src/utils/global\_options.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2529?src=pr&el=tree&filepath=packages%2Fneon_framework%2Flib%2Fsrc%2Futils%2Fglobal_options.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvbGliL3NyYy91dGlscy9nbG9iYWxfb3B0aW9ucy5kYXJ0) | `0.00% <ø> (ø)` | | | [.../neon\_framework/lib/src/utils/request\_manager.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2529?src=pr&el=tree&filepath=packages%2Fneon_framework%2Flib%2Fsrc%2Futils%2Frequest_manager.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvbGliL3NyYy91dGlscy9yZXF1ZXN0X21hbmFnZXIuZGFydA==) | `78.04% <100.00%> (+0.54%)` | :arrow_up: | | [...account\_repository/lib/src/account\_repository.dart](https://app.codecov.io/gh/nextcloud/neon/pull/2529?src=pr&el=tree&filepath=packages%2Fneon_framework%2Fpackages%2Faccount_repository%2Flib%2Fsrc%2Faccount_repository.dart&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-cGFja2FnZXMvbmVvbl9mcmFtZXdvcmsvcGFja2FnZXMvYWNjb3VudF9yZXBvc2l0b3J5L2xpYi9zcmMvYWNjb3VudF9yZXBvc2l0b3J5LmRhcnQ=) | `100.00% <100.00%> (ø)` | | | ... and [11 more](https://app.codecov.io/gh/nextcloud/neon/pull/2529?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/nextcloud/neon/pull/2529/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud)