Illustration image do not display in articles

nextcloud / news-android

📱🗞️ Android client for the Nextcloud news/feed reader app

https://play.google.com/store/apps/details?id=de.luhmer.owncloudnewsreader

GNU Affero General Public License v3.0

686 stars 258 forks source link

Illustration image do not display in articles #1325

Open louim-lbs opened 9 months ago

louim-lbs commented 9 months ago

Hi! Sadly, images are never displayed inside articles, though previews in the main page work well.

NC 27.1.3 News Android 0.9.9.83

David-Development commented 7 months ago

@louim-lbs Could you provide me with the url of the feed?

@jospoortvliet fyi the RSS link at https://nextcloud.com/blog/ leads to a 404 page 🤔

louim-lbs commented 7 months ago

For that particular article: https://nextcloud.com/blog/feed/ But in my case, image previews do not work inside articles, whatever the feed, though previews in the main page work well.

David-Development commented 4 months ago

@louim-lbs Sorry for the delay!

Could you try again using their new feed url? It seems that https://nextcloud.com/blog/feed/ no longer exists. I believe the new (correct) URL would be https://nextcloud.com/feed/ It could be that you are running into some caching issues in case the URLs for the images point to a wrong URL.

On my phone it works perfectly fine (using the new rss feed url) and I can see both the thumbnail in the list on the main page as well as the picture in full size in the detail view.

louim-lbs commented 4 months ago

Hi @David-Development, Thank you for your answer.

I already corrected the new feed to /blog/feed/, and the article texts came back.

But as far as I am concerned, no images are displayed in detail view, whatever the media provider.

Unpublished commented 4 months ago

In your screenshots the incognito icon is visible. I think if it is shown and not hidden in the 3-dot menu, incognito mode is enabled.

With incognito, images in articles are not loaded to protect privacy.

louim-lbs commented 4 months ago

In your screenshots the incognito icon is visible. I think if it is shown and not hidden in the 3-dot menu, incognito mode is enabled.

With incognito, images in articles are not loaded to protect privacy.

Oops, that's right.

So there's not really a bug. But would it be possible not to display the image canvas in this case, or to make it clear that incognito mode doesn't display them?

David-Development commented 2 months ago

@Unpublished haha.. terrific UX 🤦‍♂️ Thank you! Great catch!

@louim-lbs We could definitely try to find a better UX / solution for this (clearly I didn't even realize it when looking at the provided screenshot and I implemented this feature myself..).

Either make the "fallback" image clearer (e.g. have a text in it saying "Incognito Mode" or something) or remove the images all together like you proposed.. I feel like with the placeholders the structure of the text is still clear (e.g. in case the article talks about an image and you can see that there is an image that you enable/show by disabling the incognito mode). Also - by removing all images I think we might have this exact problem again where people might think.. wait a minute.. why is there no image here..? there should be an image in this article..

What's your take on this @Unpublished ?

Unpublished commented 2 months ago

I'm not that good/creative at UX...I agree the fallback image should incorporate incognito mode though. Maybe placing the incognito icon at the top right corner of the fallback image and reflecting incognito mode on long press on the image (at the moment it says "broken-image.png".

Removing images shouldn't be the way to go.

Maybe it would make sense to move incognito mode from action bar to settings screen and inform about measures like not downloading images in a dialog upon activation, as incognito mode is rarely toggled by me.

David-Development commented 2 months ago

@Unpublished I agree with everything you said! 😄

I also agree that it indeed could be a great idea to move them to the settings. And in fact @jancborchardt already proposed this back in the days when this feature was added 😅 (https://github.com/nextcloud/news-android/pull/791)

So the todo's would be:

[ ] placing the incognito icon at the middle / top right corner of the fallback image
[ ] long press on the image should display ("incognito-mode.png")
[ ] move incognito toggle into the settings (we can probably cleanup some logic - for example the logic that was required to apply the changes immediately when the button is toggled).

@Unpublished Does that sound about right?