search

nextcloud / news

:newspaper: RSS/Atom feed reader
https://apps.nextcloud.com/apps/news
GNU Affero General Public License v3.0
861 stars 186 forks source link

New feeds are silently ignored with misleading error! Lost tons of feeds #1993

Open thiswillbeyourgithub opened 1 year ago

thiswillbeyourgithub commented 1 year ago

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

Explain the Problem

When adding a feed. For some reason sometime the feed is malformed or something and the logging will output the "No parser can handle this stream" error. But the error does not appear anywhere else, only in the logs. I can't know if the feed was correctly added.

For months I was had been adding feeds and when trying twice in a row a red message will appear saying ""This feed already exists" when in fact it does not. Simply reloading the page shows that the warning disappears if I paste the url again.

I think the main issue is that there is no clearer warning that an error happened, and the red warning should not tell you a feed exists if it failed.

Steps to Reproduce

Explain what you did to encounter the issue

  1. try to add feed "https://bisq.network/blog/feed.atom"
  2. notice that you don't get a warning anywhere that something wrong happened
  3. paste the url a second time in the "new feed field" and notice a red warning stating that this feed already exists
  4. reload the page, paste the url a third time and notice that the warning disappeared : the feed was never added!
  5. open the nextcloud logs and see the error "no parser can handle this stream"

System Information

Contents of nextcloud/data/nextcloud.log ```json Paste output here ```
Contents of Browser Error Console Read http://ggnome.com/wiki/Using_The_Browser_Error_Console if you are unsure what to put here ``` Paste output here ```
Grotax commented 1 year ago

Yea the UI is quite broken regarding that, won't be fixed in the current code. If the new version ever gets done I'm sure we will have better error messages for the user.

thiswillbeyourgithub commented 1 year ago

Thanks for the quick reply!

To me, at least disabling the warning seems a progress as I can't imagine a user pasting twice a feed if he/she has not encountered an issue. In which case the error is misleading and will make the user think the feed was added.

I can't think of a case where the warning is useful actually.

Grotax commented 1 year ago

Yea to my understanding it's due to the integrated storage or list inside the front-end code, since it does not ask the backend for that.

And nobody is really willing to touch that code anymore. There have been only very minor changes in the past.

nursoda commented 10 months ago

Anyway, still present in News 25.0.0-alpha2 – and annoying since NC28 now shows a warning about the News app's errors(!) and warnings in /settings/admin/overview.

Grotax commented 10 months ago

@nursoda your comment doesn't make much sense to me.

To my understanding this issue was about a missing warning in the UI when you try to add a feed that is not working. The new UI has error reporting, might also not catch all cases but shows a warning if feed returns http 500 for example.

What you probably mean is that there are warnings and errors in the logs and the server now shows that directly in the overview. But what should news do about that? The warnings and errors we log are for good reasons, to check if something went wrong.

nursoda commented 10 months ago

@Grotax You're right, sorry. I was referring to /settings/admin/logging. I will try to find out where the News App errors originate from. I set my posts to hide them, you may want to do the same for yours.