Don't log requests to welcome endpoint

nextcloud / nextcloud-talk-recording

GNU Affero General Public License v3.0

12 stars 3 forks source link

Don't log requests to welcome endpoint #6

Open fancycode opened 1 year ago

fancycode commented 1 year ago

How to use GitHub

Please use the 👍 reaction to show that you are interested into the same feature.
Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
Subscribe to receive notifications on status change and new comments.

When running the recording server in Kubernetes and have probes configured for the /api/v1/welcome endpoint, the log get spammed with all the probes. It would be great if logging could be disabled for this endpoint.

nickvergessen commented 1 year ago

I don't see a log call in the welcome endpoint. Do you have a sample log message that helps us find the place?

fancycode commented 1 year ago

Sure, the entry looks like this:

INFO:werkzeug:10.42.2.1 - - [15/May/2023 13:30:08] "GET /api/v1/welcome HTTP/1.1" 200 -

nickvergessen commented 1 year ago

Ah, it's the python recording backend not PHP? 🙈

fancycode commented 1 year ago

Yeah, it's about the recording server as mentioned above :wink:

SystemKeeper commented 1 year ago

Do you need INFO to be logged? Otherwise you could change the level to WARNING? https://github.com/nextcloud/spreed/blob/c3e3edca9e6bd157e2578e3df9e35687360b0fe5/recording/server.conf.in#L5