search

nextcloud / nextcloudpi

📦 Build code for NextcloudPi: Raspberry Pi, Odroid, Rock64, curl installer...
https://nextcloudpi.com
2.56k stars 297 forks source link

Ports are shown as closed where they are in fact open #1283

Closed Menneken closed 3 years ago

Menneken commented 3 years ago

Hi, it seems I have a well known problem: NCP shows ports as closed where they are in fact open (as shown by portchecker.co). As a consequence, my installation is unable to refresh the Let´s Encrypt Certificate or do any updates. My Installation:

NextCloudPi version | v1.34.7 -- | -- NextCloudPi image | NextCloudPi_12-20-19 distribution | Raspbian GNU/Linux 10 \n \l automount | yes USB devices | sda sdb sdc datadir | /media/myCloudDrive/ncdata data in SD | no data filesystem | btrfs data disk usage | 495G/932G rootfs usage | 6.4G/59G swapfile | /var/swap dbdir | /var/lib/mysql/ncdatabase Nextcloud check | ok Nextcloud version | 20.0.4.0 HTTPD service | up PHP service | up MariaDB service | up Redis service | up Postfix service | up internet check | no port check 80 | closed port check 443 | closed
ovpc commented 3 years ago

Thought already fixed (again) in v1.36.2 https://github.com/nextcloud/nextcloudpi/releases/tag/v1.36.2 but maybe not

stoneubi commented 3 years ago

Updated from 1.35 to 1.36.2 and ports are shown as closed. Worked before update and nextcloud instance is reachable from internet. So this information is missleading.

PortsClosed

System: Raspberry4 8 GB RAM, Dietpi as distro, Nextcloud 20.0.8

nachoparker commented 3 years ago

There was a bug where they would show as open when they were actually closed.

Seems like the fix was incomplete, can't test right now since my ports are not open yet on my new ISP.

In any case, this is informational only, and does not affect Letsencrypt or anything else.

nachoparker commented 3 years ago

I might have fixed it, but can't test myself. Can someone please run sudo ncp-update devel and try again, see if it shows correctly now?

ovpc commented 3 years ago

Nope still showing closed for me in devel v1.36.3

nachoparker commented 3 years ago

ok, then I need someone else who can debug this, since my ports are closed ATM

cc @dsmic

vcbranco commented 3 years ago

version 1.36.3 showing closed here too

vcbranco commented 3 years ago

I would like to help but I don't know how

r4lix commented 3 years ago

i'm here to help too if needed

nachoparker commented 3 years ago

If someone has the skills to fix this, please send a PR. Otherwise we'll have to wait until my ports are open.

dsmic commented 3 years ago

Sorry I can not reproduce the problem. The version before your changes still works on my setup…

Haraade commented 3 years ago

Sorry I can not reproduce the problem. The version before your changes still works on my setup…

Worked, before the upgrade. This feature now creates false information for the user and is useless. A user of nextclod should know how to open router ports (80 and 443) Nextcloudpi fixes firewall (UFW) for required ports.

suxlex commented 3 years ago

Before the change from 1.35.0 to 1.36.2 both ports were shown as open and now unfortunately as closed.

nachoparker commented 3 years ago

Fixed in v1.36.3, thanks for the help!