search

nextcloud / nextcloudpi

📦 Build code for NextcloudPi: Raspberry Pi, Odroid, Rock64, curl installer...
https://nextcloudpi.com
2.49k stars 295 forks source link

Prevent nc-nextcloud-ncp notifications for Docker users #1628

Open sunjam opened 1 year ago

sunjam commented 1 year ago

With the removal of update functionality in Docker, to force users to pull images instead,

Update notifications should be be suppressed in order to avoid confusion amongst Docker users

because updating is not possible in that case without a new image.

theCalcaholic commented 1 year ago

I would actually like to keep the notification, but have it link to a documentation page explaining how to update (and how to check if your NC version is compatible)

sunjam commented 1 year ago

As long as the admin can find the proper information they need at the link, should be good.

But, we should still considering having wording displayed to the admins that helps clarify when updates apply to some admins, but not Docker/VM/container admins.

theCalcaholic commented 1 year ago

Updates should always apply to everyone. If they don't that's actually due to bugs (and should be noted in the release description)

svenb1234 commented 1 year ago

IMHO there needs to be a notification. How else would the user know that a new version/image is available? In theory for every new release a new docker image should be generated automatically, so the "there is a new version available" is not wrong but still valid.

sunjam commented 1 year ago

Theory does not match reality at this point. Currently the releases do not align, which is why I created the issue. Happy for whatever resolution makes the most sense, plus assuages user confusion.

On Sat, Oct 15, 2022 at 5:19 AM svenb1234 @.***> wrote:

IMHO there needs to be a notification. How else would the user know that a new version/image is available? In theory for every new release a new docker image should be generated automatically, so the "there is a new version available" is not wrong but still valid.

— Reply to this email directly, view it on GitHub https://github.com/nextcloud/nextcloudpi/issues/1628#issuecomment-1279734237, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANUKZXGHSF7NZVX7FIFQYLWDKOOXANCNFSM6AAAAAARB67ZVY . You are receiving this because you authored the thread.Message ID: @.***>