nextcloud / nextcloudpi

📦 Build code for NextcloudPi: Raspberry Pi, Odroid, Rock64, curl installer...
https://nextcloudpi.com
2.49k stars 295 forks source link

Feature Request: ncp-update should respect memory caching choice #1799

Closed berbigou closed 1 year ago

berbigou commented 1 year ago

Description
it seems to me that ncp-update should check if notify_push--Client Push app--Redis is in use in config.php and/or just raise a warning if not.

Example
"Warning: NCP likes Redis server, you should use it !! Messing around with config.php is not recommended !!!"

Explanations Hello, I don't use NCP the right way, I upgraded NC manually to 27.0.1 and I keep using NCP web interface even if it is not the recommended combination (for the fun, for the System-Info-page, for the scripts). During the execution of ncp-update 1.51.0 to 1.52.0, I encountered an error saying approximatively "Cannot start push_notify, redis not running". I don't use Redis but an APCu local cache as described in [https://docs.nextcloud.com/server/19/admin_manual/configuration_server/caching_configuration.html] I traced this error to /usr/local/bin/ncp-update line 45 /update.sh || exit $? and then /tmp/ncp-update.XXXXXX/update.sh line 188 start_notify_push , commenting this line got the process to run until the end (even if I don't recommend messing with scripts I didn't write myself, and I know it can mess my whole setup). So, I don't want to bother the devs with my little problems, but it seems to me that ncp-update should check if notify_push--Client Push app--Redis is in use in config.php and/or just raise a warning.

I hope this will help someone. Thanks for all your work, ncp was my entry-point to my Nextcloud adventure !

theCalcaholic commented 1 year ago

Manual configuration like setting up a custom cache is not supported with NCP. That's by design, a necessary limitation to make things easier to automate.