search

nextcloud / nextcloudpi

📦 Build code for NextcloudPi: Raspberry Pi, Odroid, Rock64, curl installer...
https://nextcloudpi.com
2.44k stars 293 forks source link

nc-update-nextcloud does not prevent updating to unsupported versions #1935

Open HansCronau opened 1 month ago

HansCronau commented 1 month ago

At the time of writing the latest version of NC supported by NCP (1.54.0) is 28.0.5. I would therefore expect nc-update-nextcloud to not update past this version, or at least throw a warning. Instead it is possible to (accidentally) enter "29.0.0" and the update will just start running without warning. (If this behavior is intended, I think documentation could be improved to better explain why this will not cause issues.)

theCalcaholic commented 1 month ago

Well it is intended but may cause issues. If you want to update to the latest supported version, you can simply enter "0". If you enter a specific version, it will perform the upgrade as requested.

I think this is mostly a UX issue that will be resolved once I get around to rewriting the web interface.

HansCronau commented 1 month ago

@theCalcaholic Thanks for your comment and amazing work.

I should probably have noted that the observation goes for both the web UI as the terminal application ncp-config, which I was using.

Because updating to the latest supported version (using "0") is not possible when a machine is multiple majors behind, I was manually updating it to "27.0.0", "28.0.0", "29.0.0", "Wait... That one shouldn't even be supported, right?" Double checks release notes while update to NC29 is running. "No, I think it shouldn't. So... whoops?" But if not, why had it just started, without warning? This created the tiniest bit of doubt for me: Did I misunderstand something about nc-update-nextcloud? I'm glad to learn I didn't and this is indeed mostly a UX issue.