nextcloud / notes-android

✎ Android client for Nextcloud Notes app.
https://play.google.com/store/apps/details?id=it.niedermann.owncloud.notes
GNU General Public License v3.0
949 stars 135 forks source link

Open in Browser #296

Closed anernest closed 6 years ago

anernest commented 7 years ago

Please consider adding a button to preview in a stock browser pulling from server. The Markdown Editor for nextcloud incorporates plugins such as Mermaidjs that don't render in the editor preview.

stefan-niedermann commented 6 years ago

Hi @anernest,

The Markdown Editor for nextcloud incorporates plugins such as Mermaidjs that don't render in the editor preview.

does it? I just tested it in my web interface with the most recent versions of nextcloud and the notes app and i could not get it work.

Is this a special setup you are running? (I assume we are both talking about the "Notes" app and not "NextNotes"?

anernest commented 6 years ago

Yes, I'm running Nextcloud 13.0.0, with Markdown Editor 2.0.4 and Notes 2.3.2 (both apps installed directly from the store). The following code will result in the directed graph being rendered (see https://mermaidjs.github.io/)

```mermaid
graph TD;
A-->B; 
A-->C; 
B-->D; 
C-->D;
```
stefan-niedermann commented 6 years ago

I can't see that the Notes app renders this markdown? Am i missing something here?

grafik

anernest commented 6 years ago

Maybe you don't have the Markdown Editor app installed or enabled for *.md files in your Nextcloud instance? In my site I can enable a preview pane (see below).

image

stefan-niedermann commented 6 years ago

So you are using the Markdown Editor app and have the Notes App only installed to be able to synchronize with the phone?

I think this is a very edgy use case. Look: Let's say we implement the button, a click should open the browser with the Markdown Editor App (since the Notes App does not support mermaid). What will people experience who have the Markdown Editor App not installed? A 404. And detecting every time whether the Markdown Editor app is installed, is still active and not deactivated? No, sorry.


I really thought about it, and i might have implemented the button to open the Notes App in browser, but detect and open a 3rd party app? Sorry, but unfortunately i have to dismiss this feature request.