search

nextcloud / notes-android

✎ Android client for Nextcloud Notes app.
https://play.google.com/store/apps/details?id=it.niedermann.owncloud.notes
GNU General Public License v3.0
907 stars 135 forks source link

Content visble behind biometric #927

Open S-360 opened 3 years ago

S-360 commented 3 years ago

I have setup a biometric lock. Why is the content of the app visible behind the lock? Shouldn't the content of the note app be masked until the app is successfully unlocked?

stefan-niedermann commented 3 years ago

It is supposed to be hidden, yes. This worked until Android Q, until Google decided to change the behavior. I don't know yet how to restore the old behavior, if you have an idea: Pull Requests are welcome 😉

cc @beatbrot and @dan0xii

S-360 commented 3 years ago

That's strange? all other apps on my device hide content until the app is unlocked with biometrics.

Running Android 10 on Samsung A50

stefan-niedermann commented 3 years ago

Maybe we have to launch another (blank) activity which itself prompts the biometric screen 🤔 This way the content would stay hidden, i guess. Will have to try this, result handling will ne a pain in the ass :-/

carabao72 commented 3 years ago

I have setup a biometric lock. Why is the content of the app visible behind the lock? Shouldn't the content of the note app be masked until the app is successfully unlocked?

Personally, to avoid displaying the note before fingerprint unlocking, I use a little trick by putting a line of 'xxxxxxxxxxxxxxxx' just after the title of the note. So I see before unlocking: note title followed by xxxxxxxxxxxx

After unlocking, i still have to click on the note to read the rest.

vhouriet commented 2 years ago

It's probably the same issue or related to that. But if you open the app and don't unlock it and then open the overview, you can see the notes as well in the overview.

Screenshot_20211005-141518_Trebuchet

I feel like local encryption should fix the problem. Even if the content is visible, it will only be gibberish then.

stefan-niedermann commented 2 years ago

@vhouriet no, this has been fixed in v3.3.0 (not yet available at the Play Store) with a setting to disable screenshots (See https://github.com/stefan-niedermann/nextcloud-notes/issues/1098). This is unrelated to the biometric issue.