search

nextcloud / notes

✎ Distraction-free notes and writing
https://apps.nextcloud.com/apps/notes
GNU Affero General Public License v3.0
604 stars 132 forks source link

Add bidi support #1191

Closed ahangarha closed 8 months ago

ahangarha commented 8 months ago

This PR is a part of a series of PRs to the NextCloud ecosystem to add bidirectional text support.

In terms of the overall layout, this PR doesn't make any changes in the UI in LTR language (and in the current state of the NextCloud server for RTL language). But it brings flexibility to the UI so that in the RTL layout, it makes automatic adjustments.

Since the editor is a third-party package, adding bidi support to it will take longer time. We might even consider other options as codemirror failed in adding bidi support for a long time. But for the Preview, I added markdown-it-bidi which is working fine now.

Screenshot (in RTL layout)

image

juliushaertl commented 8 months ago

Thanks so much for this contribution @ahangarha

ahangarha commented 8 months ago

Thanks for your review and merge.

Is there any particular reason to stick to a markdown editor based on codemirror? I am unsure how long it would take for codemirror to add bidi support.

If not, I think there are good, viable options to consider.