nextcloud / notes

✎ Distraction-free notes and writing
https://apps.nextcloud.com/apps/notes
GNU Affero General Public License v3.0
623 stars 133 forks source link

Multiple notifications are triggered with activity app #1381

Open christianlupus opened 2 months ago

christianlupus commented 2 months ago

If the activity app is enabled, each modifiaction is registered as an individual activity. This causes the notification app to going havoc if you change a shared note in regular but short intervals. Concrete example: A shared shopping list with checkboxes can be checked in the app or the web frontend while shopping. This causes me to see like 20 to 50 notifications I have to drop in order to see the important ones.

Steps to reproduce

  1. Have a NC instance with activity and notification app enabled
  2. Have file notifications enabled in feed (and optionally as mail)
  3. Share the notes folder of user A with user B
  4. As user B set storage backend to the shared folder
  5. As user B open a note (or create one) and modify it
  6. Wait a bit or close the note
  7. Continue writing

Expected behaviour

The user A is informed that the file has changed.

Actual behaviour

Each change is represented as a file written thus adding multiple notifications to the list.

Screenshots

If applicable, add screenshots to help explain your problem. image

Server

Please complete the following information.

Nextcloud configuration:

``` { "system": { "debug": true, "profiler": true, "apps_paths": [ { "path": "\/var\/www\/html\/apps", "url": "\/apps", "writable": false }, { "path": "\/var\/www\/html\/apps-extra", "url": "\/apps-extra", "writable": false }, { "path": "\/var\/www\/html\/apps-shared", "url": "\/apps-shared", "writable": false }, { "path": "\/var\/www\/html\/apps-writable", "url": "\/apps-writable", "writable": true } ], "allow_local_remote_servers": true, "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "mail_sendmailmode": "smtp", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "1025", "skeletondirectory": "\/skeleton", "setup_create_db_user": false, "loglevel": 2, "log_query": false, "query_log_file": "\/shared\/log\/querylog-nextcloud.log", "query_log_file_requestid": "yes", "diagnostics.logging": false, "diagnostics.logging.threshold": 0, "log.condition": { "apps": [ "diagnostics", "admin_audit" ] }, "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "localhost", "nextcloud", "nextcloud.local", "192.168.21.6", "localhost" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "31.0.0.3", "overwrite.cli.url": "http:\/\/nextcloud.local", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "updater.release.channel": "git", "installed": true, "instanceid": "***REMOVED SENSITIVE VALUE***", "lookup_server": "", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 6379 }, "memcache.local": "\\OC\\Memcache\\Redis", "memcache.locking": "\\OC\\Memcache\\Redis", "trusted_proxies": "***REMOVED SENSITIVE VALUE***", "app_install_overwrite": [ "calendar", "calendar_resource_management", "event_update_notification" ] } } ```

Client

Please complete the following information.

Log files

Add relevant parts of your nextcloud.log and/or your browser's JavaScript console here.

joshtrichards commented 1 month ago

Similar: nextcloud/activity#1661