nextcloud / notes

✎ Distraction-free notes and writing
https://apps.nextcloud.com/apps/notes
GNU Affero General Public License v3.0
609 stars 134 forks source link

Links not clickable #173

Open d-sko opened 6 years ago

d-sko commented 6 years ago

Hello, I've installed this app in my nextcloud and noticed a problem: I have some notes with links in it and they are not clickable (but they are actually displayed as links). Is this intended or am I doing something wrong?

nc_notes_link

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/55700149-links-not-clickable?utm_campaign=plugin&utm_content=tracker%2F46751022&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F46751022&utm_medium=issues&utm_source=github).
Larsene commented 6 years ago

Already reported here

d-sko commented 6 years ago

Oh, sorry I missed that.

Closing because duplicate of #158

jancborchardt commented 6 years ago

Reopening cause this issue is specifically about that one problem. :)

stefan-niedermann commented 6 years ago

Have you tried ctrl + click? I thought this would work...

tribut commented 6 years ago

ctrl+ click works, but it also creates a second cursor (a feature which I was not aware the markdown editor had).

tribut commented 6 years ago

Note that ctrl + click only works on manually set up links ([name](target)) while it seems to do nothing except creating multiple cursors on auto-detected urls.

stefan-niedermann commented 6 years ago

i see. single click is disabled like in microsoft word and libreoffice writer, because if one wants to edit the link or the text, one could only open the link and not set the cursor.

jancborchardt commented 6 years ago

@stefan-niedermann I’d still say we should enable single-click because Ctrl-Click is not really discoverable. If the link should be edited, people can still click next to it and use the arrow keys – I know, also not ideal, but less bad than not being able to click the link :\ Is that possible?

stefan-niedermann commented 6 years ago

Technically yes. But i would recommend to wait for the text-pop-over: Click on a link could create a pop over with an "open"-button. this way one could still click into links to edit them. What do you think?

Every other text-editor that is capable of displaying and opening links uses ctrl + click to open the links...

jancborchardt commented 6 years ago

Every other text-editor that is capable of displaying and opening links uses ctrl + click to open the links...

That's only the case for mostly code editors. :) FoldingText and iA Writer for example open links on click, and I do agree it's confusing from a user perspective that click doesn't open a link.

The popover from #200 is also only intended to come when you mark text, not when you click.

stefan-niedermann commented 6 years ago

alternatively displaying an icon right next to a link would be a solution, too?

tribut commented 6 years ago

Actually, LibreOffice only displays a tooltip on hover:

libreoffice-writer

Same behavior on Word (2010):

word-2010

If "Rightclick -> Open in new tab/window" works, I would argue ctrl+click is actually fine and consistent with other editors.

mmccarn commented 6 years ago

I would add to this that on OSX (High Sierra), \<ctrl>-click is intercepted by the OS and interpreted as a right-click, which gives me the browser right-click menu.

\<Command⌘>-click does insert extra cursors as described by tribut but still doesn't open the link.

jancborchardt commented 6 years ago

Again:

FoldingText and iA Writer for example open links on click, and I do agree it's confusing from a user perspective that click doesn't open a link.

I would say that neither LibreOffice nor Word are a really good benchmark when it comes to distraction-free working.

Right now we have the problem that you can not click the link at all and it is very cumbersome to get to it. Ctrl-click is not possible on touch-interfaces, or in touch-modes of desktop computers (like Surface etc). Hence the easiest way to fix this for now is to make clicking open the link. As you can then still modify the link by clicking next to it and then moving your cursor, or by marking, or if possible we could use ctrl-click for that.

The point being that after insertion, you probably click a link more often than you edit it. And yes, in Markdown-format links like [Text](https://…) clicking the text part of the link should not open the link so it’s easy to edit the text.

brandonkirsch commented 5 years ago

Weighing in on an old issue.

On my web browser: Ctrl+Click only follows a hyperlink when I click on one that has been formatted in Markdown properly.

I find it extremely annoying that I cannot Ctrl+Click a hyperlink that was formatted automatically when using my Desktop web browser to access Notes.

Anyone else?

jancborchardt commented 5 years ago

To support someone to fix this issue, please 💸 donate to the bounty on Bountysource! :slightly_smiling_face:

monperrus commented 1 year ago

Yes, it would be great that URLs are automatically recognized as such and made clickable (as tomboy and many other note taking apps do).