nextcloud / notes

✎ Distraction-free notes and writing
https://apps.nextcloud.com/apps/notes
GNU Affero General Public License v3.0
607 stars 134 forks source link

Doesn't support RTL text in the web app #195

Open eladhen opened 6 years ago

eladhen commented 6 years ago

The Notes app creates a text file. Most local text editors adhere to some standards concerning Right-To-Left text: starting a RTL line if the first character is in a RTL language, adhering to RTL determining character ->(‏‎) and so on. This doesn't work on the Note online editor. It shows the text LTR no matter what.

A workaround is just using a different local editor (and the android editor presumably implements some standard code, so it doesn't have this problem).

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/57978290-doesn-t-support-rtl-text-in-the-web-app?utm_campaign=plugin&utm_content=tracker%2F46751022&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F46751022&utm_medium=issues&utm_source=github).
jancborchardt commented 6 years ago

This most probably is related to the Markdown library we use? @nextcloud/notes

seyzed commented 4 years ago

Hello,

I wish it could support RTL. Its a great plugin, but its a bummer that I can't use it. Its simple and all I want. In notes in mac, when I type english it is Left to Right but when I type Arabic it is right to left.

Even an option would be handy to switch the content RTL.

Please please consider adding it.

jancborchardt commented 4 years ago

This is the editor we use, right @korelstar? https://github.com/Ionaru/easy-markdown-editor/issues

@eladhen @artaweb I couldn’t find an issue in their repository about RTL support – could you open an issue there? :) Since it’s the library we use, Nextcloud Notes supporting it is dependent on that editor supporting it.

seyzed commented 4 years ago

Just did open a feature request on that link.

jancborchardt commented 4 years ago

Thanks a lot! For reference, the issue is https://github.com/Ionaru/easy-markdown-editor/issues/202

By the way, could "direction: auto" work as well? Then it would adjust based on whatever is used, even if LTR and RTL are used both in the same sentence?

seyzed commented 4 years ago

Unfortunately, direction auto will not work. There is only 4 properties for "Direction" in css and itsltr|rtl|initial|inherit; in this case, only RTL will work.

But I think you mean dir instead of direction.

I agree that this should be something auto and can support mixed content. dir: auto could be a good handler in this scenario but after a little digging, I see that IE and EDGE does not support it.

https://www.w3.org/International/tests/repo/results/the-dir-attribute-auto

If you guys don't mind it, I don't either, who uses IE or EDGE, even so, having support for 4 major browsers is better than having for none

jancborchardt commented 4 years ago

@zayalink that would already be a very good enhancement, and we could work on Edge support in a follow-up. Do you want to propose a pull request with that change?

joshtrichards commented 1 month ago

Related:

nextcloud/text#882

nextcloud/server#31420