nextcloud / notes

✎ Distraction-free notes and writing
https://apps.nextcloud.com/apps/notes
GNU Affero General Public License v3.0
621 stars 133 forks source link

Use EasyMDE for Preview #329

Closed tnyeanderson closed 5 years ago

tnyeanderson commented 5 years ago

I took a look; we should definitely be using EasyMDE's preview functionality instead of Markdown-It. It supports checkboxes out of the box and prevents us from requiring another library. Here's what EasyMDE does not support that Markdown-It does:

Since we don't support these features anyway, making the switch makes sense.

Some useful notes for implementation: Check if we are in preview mode: easyMDE.isPreviewActive(); Toggle preview mode: easyMDE.togglePreview()

This should be easy to implement. Then we can get rid of Markdown-It, AND have checkboxes available in preview mode :)

korelstar commented 5 years ago

This will be obsolete due to #331. Did you already did some implementation on this or can we safely close this issue, @tnyeanderson?

tnyeanderson commented 5 years ago

You're absolutely right. Closing.