nextcloud / notes

✎ Distraction-free notes and writing
https://apps.nextcloud.com/apps/notes
GNU Affero General Public License v3.0
612 stars 134 forks source link

Add toolbar to native markdown editor #788

Open newhinton opened 2 years ago

newhinton commented 2 years ago

Is your feature request related to a problem? Please describe. It's an improvement for people who are not that fluent in in markdown syntax.

Describe the solution you'd like grafik

Additional context https://github.com/nextcloud/notes/pull/785#issuecomment-985077296 This is similar to the toolbar nextcloud/text provides

I already started working on this, PR' follows later.

Todo:

In my trials i also centered the content properly. It is not anchored to the left sidebar anymore, so that the content stays centered. This is useful for wide screens

newhinton commented 2 years ago

grafik

This is how it looks like with proper icons. I am currently waiting for text#1996 so that we know if we can use all their icons. Most of them are from https://google.github.io/material-design-icons/ so we should be fine since it uses Apache 2 if we stick to that license

As to the new image upload/selection: I think with this toolbar we can easily do both. The nextcloud-native selector gets a prominent icon in the toolbar, and upload-from-local is moved as an option to the overhang menu. that way we have both, but do not clutter the ui

dodedodo commented 2 years ago

I'd love to see a toolbar in the editor. But why not just use the nextcloud 'text' markdown editor as a whole?

nextcloud/text #884 has some more info on this. Nextcloud Collectives has already implemented text as its markdown editor.

newhinton commented 2 years ago

@dodedodo Because the "markdown-editor" the text app uses is deeply flawed. It reliably breaks markdown files and does not adhere to 'standards' and conventions. Until it stops beeing destructive it will probably not replace the one we use. I will link to the discussion later that explains the issue more deeply

Edit:

Here is the link to the discussion: https://github.com/nextcloud/text/issues/593

szaimen commented 2 years ago

@dodedodo Because the "markdown-editor" the text app uses is deeply flawed. It reliably breaks markdown files and does not adhere to 'standards' and conventions. Until it stops beeing destructive it will probably not replace the one we use. I will link to the discussion later that explains the issue more deeply

Edit:

Here is the link to the discussion: nextcloud/text#593

This is now mostly resolved for NC25 IIRC

szaimen commented 2 years ago

It is even possible to integrate the text app as npm package afaik...

stefan-niedermann commented 2 years ago

@szaimen please see the pinned issue https://github.com/nextcloud/notes/issues/331 for information about why a Nextcloud Text integration is currently blocked.