search

nextcloud / notifications

:bell: Notifications app for Nextcloud
GNU Affero General Public License v3.0
114 stars 53 forks source link

notification bell does not adapt to theme, always white #1962

Closed blizzz closed 3 hours ago

blizzz commented 3 days ago

Steps to reproduce

  1. Run notifications from master
  2. Have a background that will have icons black, also dark mode
  3. Look at the notification bell

Expected behaviour

The bell is black

Actual behaviour

It is an old, white bell

Screenshot_20240628_221929

This also happened after increasing the cachebuster, and also when switiching to light mode (all icons are black, but the bell)

I have not seen a similar bug report so far. Apologies if I oversaw one.

cc @Antreesy

nickvergessen commented 3 days ago

Can you share the image and the theming color?

Antreesy commented 3 days ago

Found related server change for 29, but it wasn't backported to main: https://github.com/nextcloud/server/pull/45430

UnifiedSearch and ContactsMenu have this internal style, Notifications App doesn't

#header .header-menu__trigger-icon {
    color: var(--color-background-plain-text) !important;
}

Plain solution would be to add it, but whenever next change comes, we need to fix it again in three different places So I'd say, should be fixed in vue-library? (cc @susnux )

blizzz commented 10 hours ago

Can you share the image and the theming color?

If still relevant, it is one of the shipped images:

Screenshot_20240702_113540

Dark mode (via system pref), and primary color is Nextcloud blue / #006789