Support SystemD `Type=notify`

nextcloud / notify_push

Update notifications for nextcloud clients

GNU Affero General Public License v3.0

224 stars 40 forks source link

Support SystemD `Type=notify` #456

Closed Deric-W closed 3 months ago

Deric-W commented 3 months ago

By compiling with the optional feature systemd the service representing the push server can be configured with Type=notify.

This allows actions depending on the service being operational (like occ notify_push:setup) to be delayed until things like connections or Unix domain sockets have been established.

The following things might be debatable:

using an external dependency for notifying SystemD
notifying SystemD in a blocking manner from within a future

Closes #452

icewind1991 commented 3 months ago

If I understand the sd-notify library correctly. If we ignore any error from sending the notification, there shouldn't be any issue with trying to send the notification on non-systemd systems and having the feature enabled by default.

Deric-W commented 3 months ago

When the required environment variable is not present the function just returns Ok(()) which means we don't have to ignore errors.

github-actions[bot] commented 2 months ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!