search

nextcloud / passman-android

:key: Android app for Passman.
https://passman.cc
GNU General Public License v3.0
92 stars 30 forks source link

Add searchbar #32

Closed seddarj closed 6 years ago

seddarj commented 6 years ago

Implement filtering of credential list based on search input.

Related to #24 searchbar

seddarj commented 6 years ago

Sure, it's just that I can only work on this a few hours here and there when I have the time. Mostly on the weekends when I'm not busy with other things.

If there are other people interested in taking this one, I don't mind :-)

seddarj commented 6 years ago

@animalillo I've added interfaces and used generic types where possible. This should make it more reusable.

The FilterListAsyncTask isn't very flexible because of the duplicate OnListFragmentInteractionListener in the CredentialItemFragment and VaultFragment classes but it can be used in either case hopefully.

Performance/feature wise, it works just as well as my previous implementation on my phone.

seddarj commented 6 years ago

@animalillo Have you had time to look over the changes and decide whether to merge this or not?

animalillo commented 6 years ago

Yup, sorry, i have been quiet busy lately.

I have reviewed your changes and it looks pretty good now, merging.

Thanks a lot! I think @brantje is going to love your feature :P he has over 600 items and said it seems to work quiet fast for him.

seddarj commented 6 years ago

@animalillo Thanks for merging it! I'm glad it's useful to someone ;-)