nextcloud / passman-android

:key: Android app for Passman.
https://passman.cc
GNU General Public License v3.0
93 stars 30 forks source link

Feature credential display auto link url #60

Closed HahUK closed 5 years ago

HahUK commented 5 years ago

Hi,

Please can you accept this pull request to allow Android to generate clickable links for URLs when displaying a credential.

fixes #58

Note, there are two different commits here. b5047ff implements URL as a CopyTextItem. This has a bug when deeplinking into Applications in that the application launches and is modal but might not be visible. b20e169 implements this by setting autoLinks="all" on the TextView. This has the limitation of not allowing the URL to be copied and pasted and so does not fully fix #58.

Thanks,

Tom

animalillo commented 5 years ago

It looks good to me, i shoul test it and most likely merge it for the next release