search

nextcloud / passman-android

:key: Android app for Passman.
https://passman.cc
GNU General Public License v3.0
92 stars 30 forks source link

WIP: general ui improvements and authentication changes. #64

Closed Tomasu closed 6 months ago

Tomasu commented 5 years ago

Hi,

I've made a few changes that (imo) improve the ui flow a bit and fix some minor theming issues, and made it authenticate using the nextcloud app.

This is not a formal pull request as its still quite messy and can't yet fall back to another form of authentication. I'm planning on adding Oauth support.

I'm mostly just making this PR to announce that it exists and requesting comments and feedback.

animalillo commented 5 years ago

I've added that tiny comment as I've seen gms referenced, I hope I get some time to properly look into your merge request as it seems to have a real lot of changes and looks very interesting indeed.

Tomasu commented 5 years ago

I've added that tiny comment as I've seen gms referenced, I hope I get some time to properly look into your merge request as it seems to have a real lot of changes and looks very interesting indeed.

I fully expect to be doing a bunch more. I will try to keep changes in more descreet commits, but sometimes it's a bit difficult when working through issues. I'm planning on doing some refactoring to more modern android practices like the jetpack architecture and ui components.

Also, the fancy authentication that's built in requires a change in the nextcloud files app (see: https://github.com/nextcloud/android/issues/4047) to behave as intended.

animalillo commented 5 years ago

@Tomasu if you wish, we can discuss plans and changes on telegram that is the main platform we've been using for communication, poke me at https://t.me/passman_general and i will make sure to add you on the proper dev groups

Tomasu commented 5 years ago

@Tomasu if you wish, we can discuss plans and changes on telegram that is the main platform we've been using for communication, poke me at https://t.me/passman_general and i will make sure to add you on the proper dev groups

Who are you on telegram? Just signed up and I'm in passman_general now. first time I've used telegram.

binsky08 commented 6 months ago

slightly outdated; close draft because there is no current activity