nextcloud / passman-android

:key: Android app for Passman.
https://passman.cc
GNU General Public License v3.0
92 stars 30 forks source link

Major improvements (added encryption functionality and more) #74

Closed binsky08 closed 3 years ago

binsky08 commented 4 years ago
binsky08 commented 4 years ago

This is what i have seen today, didn't get time to check all the changed files though, but there is a few things we can check around here. Not all of my comments require a change on the code, but are more like "things we can discuss".

I have not checked the Java encryption implementation though, as i believe that at the end only one of the two should stay on the final revision. If you think that the java implementation is better we can discuss that though.

Java crypto part completely removed